filter name is random "filter232" when first added

Bug #1089406 reported by insaner on 2012-12-12
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Low
insaner

Bug Description

on 11889

it seems when you add a filter from the menu ("Filters" > [any]) the filters dialog does not show the name of the selected filter, but some random "filter828" number or so.. adding a new filter sets the name correctly for the previous filter, but then sets the name for the new filter as "filter899" or so (increments by a few). clicking on the "New" button in the filter dialog sets the proper name. this of course, unless you clicked on the randomly (i guess sequentially) generated name and had it go into the "edit filter name" mode.. in which case, it can no longer automatically fix itself.

luckily, ive been poking around the code, and will submit a patch below that will hopefully be the solution.

insaner (insaner) wrote :

hope this is the right way to make a patch.. thanks to su_v and john-smithi for the help

su_v (suv-lp) wrote :

Also reported earlier (as first of two issues) in
- Bug #390165 “Filter editor problems (unable to reapply filters)”
  <https://bugs.launchpad.net/inkscape/+bug/390165>
and mentioned in comment #1 of
- Bug #1006816 “Newly applied filter doesn't show in Filters Editor”
  <https://bugs.launchpad.net/inkscape/+bug/1006816>

tags: added: filters-svg ui
Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
su_v (suv-lp) on 2012-12-12
Changed in inkscape:
assignee: nobody → insaner (insaner)
status: Triaged → In Progress
jazzynico (jazzynico) wrote :

Patch tested successfully on Windows XP, Inkscape trunk revision 12010.

Changed in inkscape:
milestone: none → 0.49
tags: added: backport-proposed
insaner (insaner) wrote :

if the patch worked, and fixed the problem, can someone check in the changes? (i dont have commit power)

jazzynico (jazzynico) wrote :

Fix committed in the trunk, revision 12012.
Thanks insaner!

Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico) wrote :

Also fixes Bug #1098060 "Filter Editor doesn't remember what filter type is used after an "undo/redo" is done".

su_v (suv-lp) wrote :

Committed fix (r12012) breaks editing of individual filter primitives of compound filter effects:
- Bug #1111459 “Filters editor jumps to the first primitive”
  <https://bugs.launchpad.net/inkscape/+bug/1111459>

su_v (suv-lp) wrote :

Proposing to revert r12012 until there's a better fix available which doesn't trigger bug #1111459.

insaner (insaner) wrote :

does reverting the patch locally fix the problem in Bug #1111459 ?

su_v (suv-lp) wrote :

See comment 3 in bug #1111459.

su_v (suv-lp) wrote :

Changes from r12012 reverted in r12137 (see comment #11 in bug #1111459).

@insaner - I'm leaving the bug assigned to you, and set the bug status to 'In Progress' for now: maybe you can find a more fine-grained solution to update only the filter effect names in the filter list on the left, without affecting other basic usage of the filter editor (bug #1111459)?

Please comment if you disagree with any of the changes.

Changed in inkscape:
status: Fix Committed → In Progress
insaner (insaner) wrote :

alright, this seems to fix the "jumping" problem.. however im aware its not the perfect fix, i just cant seem to find how to call "update_filters" from the filters.cpp file, or to set the label properly when the filter is added, which would be the best fix of all..

also, this fix reveals that the same problem exists when "merging" filters, ie, when you set a filter (even via the "new" button in the filters dialog) and then select another filter from the filters menu.. the filter name is later changed to the last filter selected (but not right away).. not sure if its better to open a bug for this last one ("do not change name of filter when merging filters") or the first one ("filter name not updated right away when merging filters") ill let you guys decide what is best

in the mean time, heres a patch that should close this bug

insaner (insaner) wrote :

i will be checking this in hopefully by friday. let me know if there are any issues

jazzynico (jazzynico) wrote :

Tested successfully on Windows XP, Inkscape 12224. The fix seems tricky indeed, but works as expected.

> this fix reveals that the same problem exists when "merging" filters

Confirmed. As an Inkscape user, I'd prefer that the filter's name doesn't change. Particularly when I modified it myself...

insaner (insaner) on 2013-03-22
Changed in inkscape:
status: In Progress → Fix Committed
su_v (suv-lp) wrote :

r12232 backported to lp:inkscape/0.48.x (applies and compiles on OS X, but I haven't tested it at runtime)

su_v (suv-lp) wrote :

Fix backported to lp:inkscape/0.48.x in revision 10000.

Changed in inkscape:
milestone: 0.49 → 0.48.5
tags: removed: backport-proposed
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers