major update of Jitter Nodes extension

Bug #1071833 reported by JPi on 2012-10-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Wishlist
JPi

Bug Description

The jitter nodes extension wasn't working as expected.

It basically generated a random displacement vector and added that to the nodes.

The angle was chosen form a uniform distribution and the radius set using the user provided values. Therefore the option "use normal distribution" was useless. Also, some random numbers were calculated with different distributions but never used.

I re-wrote the randomize subfunction to generate displacements according to different distributions. Specially I added two long tailed distributions to get spiky jitter (I will create some tutorials using them).

Consequently I also updated the associated .inx file.

Since the changes are considerable I decided to rename the function to jitternodes. I added my name to the Copyright and kept the original author as well.

This version of the extension is, imho, more practical than the previous one.

Please let me know if you find any problems.

Related branches

JPi (ajuanpi) wrote :
description: updated
JPi (ajuanpi) wrote :

I forgot to add the changes to
share/extensions/Makefile.am

Here they are.

Thank you for reviewing

su_v (suv-lp) wrote :

The first patch didn't apply cleanly for me (I failed to figure out why) - attaching a new diff with the changes against the original files (radiusrand.{inx,py}).

The two extensions files can then be renamed within bzr in a second step, and the patch for 'share/extensions/Makefile.am' applied:
$ bzr mv share/extensions/radiusrand.py share/extensions/jitternodes.py
$ bzr mv share/extensions/radiusrand.inx share/extensions/jitternodes.inx

This would allow to keep track of the modifications in the bzr history.

su_v (suv-lp) wrote :

Patch (now with typo from original fixed)

su_v (suv-lp) on 2012-10-26
Changed in inkscape:
importance: Undecided → Wishlist
status: New → Confirmed
JPi (ajuanpi) wrote :

Here is a plot showing the ineffective flag in the old version and the features of the new version.

Spike distributions are much more suited to simulate scribbles and ripped paper details. In the future I will add a flag to use one sided distributions (i.e. displacements only in the positive direction).

jazzynico (jazzynico) on 2012-10-27
Changed in inkscape:
assignee: nobody → JPi (ajuanpi)
status: Confirmed → In Progress
su_v (suv-lp) wrote :

@JPi - is your branch ready to be reviewed for merging? (just curious ;-) )

JPi (ajuanpi) wrote :

@~suv - Sorry for the delay. I am traveling these days. I will be back on Feb. and get this done.

Thanks for pinging.

JPi

jazzynico (jazzynico) wrote :

New patch based on trunk rev. 14909.
Tested successfully on Windows XP (32-bit).

Proposing to commit now so that it's available in Inkscape 0.92.

Changed in inkscape:
milestone: none → 0.92
jazzynico (jazzynico) wrote :

Updated applied to the trunk, rev. 14912.
Thanks for the patch JPi!

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2017-01-10
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers