Markers customized colors not persistent

Bug #1055796 reported by jazzynico
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Inkscape
Invalid
Medium
Unassigned

Bug Description

Clicking on an objects automatically remove colors applied with the Color markers extension.

Steps:
1. Draw an object with markers.
2. Modify the markers' attributes with Extensions>Modify Path>Color Markers.
3. Click again on the object -> the markers are colored back with the object's colors.

Revision history for this message
jazzynico (jazzynico) wrote :

Note that it's not due to the extension itself. Modifying the markers colors directly in the XML editor leads to the same result.

tags: added: color markers
Changed in inkscape:
importance: Undecided → Medium
Revision history for this message
jazzynico (jazzynico) wrote :

Setting milestone to 0.49.
If not fixed, the extension is completely useless and thus should be removed.

Changed in inkscape:
milestone: none → 0.49
Revision history for this message
su_v (suv-lp) wrote :

AFAIU if one modifies the colors of stock markers, and does not want them to be updated, one has to change the preferences for the marker behavior and disable the feature to auto-update stock markers.

Revision history for this message
jazzynico (jazzynico) wrote :

The issue comes from the fact that the marker's colors are updated by actions that have nothing to do with changing the object's colors or style. Just clicking on the object should not auto-update the colors and revert the changes applied with the extension IMHO.

Thus having both the extension and the auto-update feature (as it works today) on by default is quite confusing (and is likely to lead to bug reports...).

su_v (suv-lp)
Changed in inkscape:
status: New → Confirmed
jazzynico (jazzynico)
Changed in inkscape:
status: Confirmed → Triaged
Revision history for this message
Ryan Lerch (ryanlerch) wrote :

So it appears that the auto-update only happens with the stock markers (i assume markers with the custom attribute inkscape:isstock)

Would a fix for this one be to update the extension to remove this attribute on the marker when the user changes the marker colour with the extension.

Although, this does not fix the use-case of the user that creates a custom marker, and wants it to auto-update with the stroke.

jazzynico (jazzynico)
summary: - Markers customized colors not persistant
+ Markers customized colors not persistent
Revision history for this message
su_v (suv-lp) wrote :

@JazzyNico - what should be done at this point? With string and feature freeze for 0.91.x in place, should we move the milestone to 0.92?

Revision history for this message
jazzynico (jazzynico) wrote :

~suv> should we move the milestone to 0.92?

Yes. But in the meantime, I suggest we disable the (now completely useless) extension in 0.91.

Changed in inkscape:
milestone: 0.91 → 0.92
Revision history for this message
jazzynico (jazzynico) wrote :

Extension disabled in the 0.91.x branch, revision 13684.

Revision history for this message
Tavmjong Bah (tavmjong-free) wrote :

The optimal solution is to implement SVG 2 contextFillPaint and contextFillStroke key words with an SVG1.1 fallback on export.

The key words have been agreed to by the SVG working group but have not been updated in the text.

See: http://www.w3.org/TR/SVG2/painting.html#SpecifyingPaint

Revision history for this message
Tavmjong Bah (tavmjong-free) wrote :

I have implemented the SVG 2 solution in trunk r13688 (without SVG 1.1 fallback). It should be viewed as experimental at the moment. There is one test marker included at the Inkscape provided markers (at end of markers.svg).

Revision history for this message
jazzynico (jazzynico) wrote :

Attached is a test version of the Color Markers extension that uses the new context-fill and context-stroke attributes (first disable the options in the preferences dialog [Markers tab])

Revision history for this message
jazzynico (jazzynico) wrote :

The new SVG 2 features are very interesting. They would allow us to disable the markers default options in the preferences (or even completely revert the related changes to the code) and get rid of the interferences with manual marker color modifications.

FTR, the automatic markers feature were applied revisions 11614, 11671 and 11699 (see Bug #165865 "markers must take object's stroke color (SVG 1.2 feature)").

su_v (suv-lp)
tags: added: extensions-plugins
Revision history for this message
Jens Kober (jkober) wrote :

The bug is still present in 0.92 (on a clean install Win/msi/64bit the extension is enabled and I get the same behavior is described in the initial bug report)

jazzynico (jazzynico)
Changed in inkscape:
milestone: 0.92 → 0.93
Revision history for this message
Jonathan Hofinger (jhofinger) wrote :

Closing. In Inkscape 1.2, the behavior is now described in https://gitlab.com/inkscape/inbox/-/issues/6194.

Closed by: https://gitlab.com/jhofinger

Changed in inkscape:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.