Activity log for bug #1017123

Date Who What changed Old value New value Message
2012-06-24 11:35:53 su_v bug added bug
2012-06-24 11:35:53 su_v attachment added pdf-input-fix-line-width.diff https://bugs.launchpad.net/bugs/1017123/+attachment/3202401/+files/pdf-input-fix-line-width.diff
2012-06-24 11:36:15 su_v attachment added drawing-1.svg https://bugs.launchpad.net/inkscape/+bug/1017123/+attachment/3202402/+files/drawing-1.svg
2012-06-24 11:36:30 su_v attachment added drawing-1.pdf https://bugs.launchpad.net/inkscape/+bug/1017123/+attachment/3202403/+files/drawing-1.pdf
2012-06-24 11:37:08 su_v attachment added drawing-1-normal-pdf-import.svg https://bugs.launchpad.net/inkscape/+bug/1017123/+attachment/3202404/+files/drawing-1-normal-pdf-import.svg
2012-06-24 11:37:26 su_v attachment added drawing-1-poppler-cairo-pdf-import-unpatched.svg https://bugs.launchpad.net/inkscape/+bug/1017123/+attachment/3202405/+files/drawing-1-poppler-cairo-pdf-import-unpatched.svg
2012-06-24 11:37:43 su_v attachment added drawing-1-poppler-cairo-pdf-import-patched.svg https://bugs.launchpad.net/inkscape/+bug/1017123/+attachment/3202406/+files/drawing-1-poppler-cairo-pdf-import-patched.svg
2012-06-24 11:58:11 su_v description Importing PDFs via the experimentally enabled 'Adobe PDF via poppler-cairo (*.pdf)' input extension lacks precision and incorrectly adjusts line widths (thin lines default to 1px). Based on the information [2] provided in a ticket filed for 'pdf2svg' (also based on poppler-cairo) in MacPorts [1] I tried to apply the same changes to Inkscape's import routine based on poppler-cairo, which produces the intentioned improvements for line drawings (but apparently introduces a regression with regard to PDF elements converted into pattern-filled SVG objects [2]). The proposed patch needs to be reviewed by someone familiar with both poppler and cairo - I haven't tested it extensively with other PDF files, but the problem with bad precision and incorrect line widths can be reproduced both with externally created PDF files as well as with PDF files created by Inkscape (see attached samples). Tested with current trunk r11512 (unpatched and patched) on OS X 10.7.4, with poppler 0.18.4 and cairo 1.12.2 installed. --- [1] <https://trac.macports.org/ticket/32270> [2] the ticket quotes a conversion on irc with cairo developer Adrian Johnson: <wagle> if pdf2svg uses poppler, and now draws lines too thick compared to 6-9 months ago, is poppler the one at fault? The lines used to be 0.398 thick, are now 1 <adrianj> wagle: pdf2svg should be calling poppler_page_render_for_printing() instead of poppler_page_render(). The former is for use with cairo vector surfaces. The latter for image surfaces. <adrianj> The stroke adjust feature will cause lines < 1 wide to be adjusted to 1 pixel wide but only for image surfaces. [3] See also the files attached in (private) bug #1009438 "Cannot Import Vector PDFs with large number of paths" Importing PDFs via the experimentally enabled 'Adobe PDF via poppler-cairo (*.pdf)' input extension lacks precision and incorrectly adjusts line widths (thin lines default to 1px). Based on the information [2] provided in a ticket filed for 'pdf2svg' (also based on poppler-cairo) in MacPorts [1] I tried to apply the same changes to Inkscape's import routine based on poppler-cairo, which produces the intentioned improvements for line drawings (but apparently introduces a regression with regard to PDF elements converted into pattern-filled SVG objects [3]). The proposed patch needs to be reviewed by someone familiar with both poppler and cairo - I haven't tested it extensively with other PDF files, but the problem with bad precision and incorrect line widths can be reproduced both with externally created PDF files as well as with PDF files created by Inkscape (see attached samples). Tested with current trunk r11512 (unpatched and patched) on OS X 10.7.4, with poppler 0.18.4 and cairo 1.12.2 installed. --- [1] <https://trac.macports.org/ticket/32270> [2] the ticket quotes a conversion on irc with cairo developer Adrian Johnson: <wagle> if pdf2svg uses poppler, and now draws lines too thick compared to 6-9 months ago, is poppler the one at fault? The lines used to be 0.398 thick, are now 1 <adrianj> wagle: pdf2svg should be calling poppler_page_render_for_printing() instead of poppler_page_render(). The former is for use with cairo vector surfaces. The latter for image surfaces. <adrianj> The stroke adjust feature will cause lines < 1 wide to be adjusted to 1 pixel wide but only for image surfaces. [3] See also the files attached in (private) bug #1009438 "Cannot Import Vector PDFs with large number of paths"
2012-10-05 14:50:06 su_v inkscape: status New Confirmed
2012-11-10 14:16:33 su_v attachment added 1017123-pdf-input-fix-line-width-v2.diff https://bugs.launchpad.net/inkscape/+bug/1017123/+attachment/3429479/+files/1017123-pdf-input-fix-line-width-v2.diff
2014-04-11 20:18:44 theAdib inkscape: importance Undecided Medium
2014-04-11 20:18:52 theAdib inkscape: assignee theAdib (theadib)
2014-04-11 20:18:59 theAdib inkscape: milestone 0.91
2014-04-13 16:52:37 Launchpad Janitor branch linked lp:inkscape
2014-04-13 16:56:11 theAdib inkscape: status Confirmed Fix Committed
2015-02-12 11:57:53 Alex Valavanis inkscape: status Fix Committed Fix Released