GTK3: status bar of XML Editor triggers resize of dialog window

Bug #1016889 reported by su_v
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
jazzynico

Bug Description

Similar to bug #1011332 "Window resize issues in GTK3 build":
The width of the (dockable) XML Editor dialog changes each time the length of the message in the dialog's status bar changes.

Steps to reproduce:
1) launch Inkscape
2) draw a path, keep it selected
3) open XML Editor
4) select different attributes in the upper right window frame

Expected result:
Width of the docked dialog stays fixed.

Actual result:
Width of the docked dialog adjusts to the length of the message displayed in the dialog's status bar.

Tested with Inkscape 0.48+devel r11512 on OS X 10.7.4
glib 2.32.3, gtk3/x11 3.4.3, gtkmm 3.4.0

Tags: gtk3 ui
su_v (suv-lp)
description: updated
ScislaC (scislac)
Changed in inkscape:
status: New → Confirmed
importance: Undecided → Medium
tags: added: gtk3
removed: gtk3-regression
Revision history for this message
Marek (abulak) wrote :

I have no idea if this is related but I'm facing LPE dialog which is 3400 pixels wide.

Also Text and Font dialog is 1500 pixel wide which is aruably ok on my 1920p screen.
This was totally unacceptable on 1366x768

Revision history for this message
Marek (abulak) wrote :

Wait, it's Pattern along path LPE that makes it so wide?!

jazzynico (jazzynico)
Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
milestone: none → 0.91
status: Confirmed → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Patch attached.
The label line is wrapped if the text length exceeds the Widget's size.
It works correctly on Crunchbang Waldorf with Gtk-3.4.2, but not with Gtk-2.24.10 (the text breaks after every word).

Revision history for this message
su_v (suv-lp) wrote :

Patch tested successfully on OS X 10.7.5 with
- GTK+/X11 3.4.3
- GTK+/Quartz 3.6.4
- GTK3/X11 3.10.7
- GTK3/Quartz 3.10.7

Depending on the font size, and dialog width, the patched version now expands the height of the docked dialog if needed. Is there a max length defined somewhere for the message displayed in the status bar of the XML Editor?

--
Corrected version of comment #4 (tested GTK+ 3.10.7 with wrong aka unpatched builds)

Revision history for this message
jazzynico (jazzynico) wrote :

> Is there a max length defined somewhere for the message displayed in the status bar of the XML Editor?

No. There's a requested size for the whole XML dialog, but no maximum for the message itself.

Note that I'm still wondering why using a wrapped text doesn't give the same result with GTK-2 (to be precise, I'm a bit surprise it does work correctly with GTK-3 without additional code...).
Investigations in progress...

Revision history for this message
jazzynico (jazzynico) wrote :

Patch committed revision 13155.

Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.