[ClearWeather] screenlet does not remember ZIP from previous session

[Aditya Kher]

In short:
      This bug affects only Spanish translation. ZIP is translated twice.
      The applet don't remember the ZIP code from session to session.
      Please check line 95 in ClearWeatherScreenlet.py file:

self.add_option(StringOption(_('Weather'), 'ZIP', #<<< don't translate this ZIP string
 str(self.ZIP), _('ZIP'), _('The ZIP code to be monitored taken from Weather.com')), realtime=False)

[Manos Nikiforakis (nikiforakis-m)]

Indeed it has to do with the translation. It doen't affect me with the greek translation, although something is not good with the hu.po. I had some issues commiting yesterday that had to do with hu.po. To resolve the conflicts reported I had to comment some lines, one of them had to do with ZIP Code. So It may be my fault. Please Papp check hu.po...

[Manos Nikiforakis (nikiforakis-m)]

Wrong! It does affect me, so I'll change the ZIP string not to be translated in the next commit..

[Manos Nikiforakis (nikiforakis-m)]

I was reffering to Freemeteo weather screenlet that has the same problem...

[Aditya Kher (adityak)]

I spent some time on this and note that "session" of the screenlet remembers previous ZIP code alright if you "Quit" the screenlet instance. The screenlet ofcourse will not remember any previous values if you "Delete" the screenlet instance since the session is removed from /tmp/screenlets/screenlets.username.running

It is suggested that you change the default ZIP value in ClearWeather.py to desired setting if you want to set to a different ZIP after deleting the screenlet instance.

[Gabriel Dubatti (gdubatti)]

The problem is present in the Spanish translation ("ZIP" is translated as "CP").
There are two different ZIP codes depending the way you check it (using the menu or using the properties option).
When I modified line 95 as in the bug description, the problem is solved.

This is the content of my ClearWeather1.ini file:
--------
scale=2.0
theme_name=default
ZIP=ARBA0009
is_sticky=True
is_widget=False
draw_buttons=True
keep_above=False
lock_position=False
is_dragged=False
keep_below=True
y=204
x=1000
skip_taskbar=True
CP=ARBA0009
-------------
As you can see there are 2 different entrys for the ZIP code: "ZIP" and "CP".

After every screenlets update, I have to modified line 95 by hand to correct the problem.

[Aditya Kher (adityak)]

Kindly open a separate bug specific to spanish translation

[Papp Bence (sclegnrbs)]

Fix committed rev. 831.