free-memory-read crash in indicator-sound-service's file monitoring
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Sound Menu |
Fix Released
|
Medium
|
Charles Kerr |
Bug Description
Okay, this is a fun one.
Found while investigating lp bug #949837 ... the closure in establish_
The workaround has two parts:
1. Create a local *unowned* copy of "monitor" for use in the closure. This prevents the closure from holding onto a reference, solving the problem of it trying to free the monitor whenever it gets freed.
2. Since the first step removed our closure's reference to FileMonitor, the monitor is freed at the end of establish_
Related branches
- Conor Curran (community): Approve
-
Diff: 98 lines (+33/-25)2 files modifiedsrc/music-player-bridge.vala (+15/-11)
src/settings-manager.vala (+18/-14)
Changed in indicator-sound: | |
status: | In Progress → Fix Committed |
Changed in indicator-sound: | |
milestone: | none → 0.8.5 |
Changed in indicator-sound: | |
status: | Fix Committed → Fix Released |