i-sound slider on unmute resets volume
Bug #921065 reported by
Conor Curran
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Indicator Display Objects |
Fix Released
|
Medium
|
Charles Kerr | ||
The Sound Menu |
Fix Released
|
Medium
|
Charles Kerr |
Bug Description
- Amplify volume over 100% using sound settings
- mute/unmute using keyboard
- volume resets to 100% and the over amplifed level from before
Related branches
lp:~charlesk/ido/lp-921065
Merged
into
lp:ido/0.3
- Conor Curran (community): Approve
-
Diff: 1042 lines (+121/-734)5 files modifiedsrc/Makefile.am (+0/-15)
src/idooffscreenproxy.c (+0/-515)
src/idooffscreenproxy.h (+0/-62)
src/idoscalemenuitem.c (+113/-140)
src/idoscalemenuitem.h (+8/-2)
lp:~charlesk/indicator-sound/lp-921065
- Conor Curran (community): Approve
-
Diff: 87 lines (+28/-28)1 file modifiedsrc/volume-widget.c (+28/-28)
lp:ubuntu/lucid/indicator-sound
(Merged)
Changed in indicator-sound: | |
assignee: | nobody → Conor Curran (cjcurran) |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → 0.8.1.0 |
Changed in indicator-sound: | |
status: | Triaged → Confirmed |
Changed in indicator-sound: | |
milestone: | 0.8.1.0 → 0.8.2.0 |
Changed in indicator-sound: | |
status: | Confirmed → Triaged |
status: | Triaged → In Progress |
Changed in indicator-sound: | |
milestone: | 0.8.2.0 → 0.8.3.0 |
Changed in indicator-sound: | |
milestone: | 0.8.3.0 → none |
Changed in indicator-sound: | |
status: | In Progress → Incomplete |
status: | Incomplete → Opinion |
status: | Opinion → Incomplete |
assignee: | Conor Curran (cjcurran) → charles (charlesk) |
Changed in indicator-sound: | |
status: | Incomplete → In Progress |
Changed in ido: | |
status: | New → In Progress |
assignee: | nobody → charles (charlesk) |
Changed in ido: | |
status: | In Progress → Fix Committed |
Changed in indicator-sound: | |
status: | In Progress → Fix Committed |
Changed in indicator-sound: | |
milestone: | none → 0.8.4.0 |
Changed in ido: | |
milestone: | none → 0.3.3 |
Changed in ido: | |
importance: | Undecided → Medium |
Changed in ido: | |
status: | Fix Committed → Fix Released |
Changed in indicator-sound: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This happens because one of the feature requests around the slider is allow the user to click on either icon on either end to maximise or minimize the volume.
The only way i-sound then listens for this event is to subscribe to the 'value-changed' callback which when it is received will set the PA volume according to the slider position.
Because obviously the value-changed signal gets fired every time the slider moves due to user interaction or otherwise I need to filter the events to only listen to what i think are relevant (mouse click on ido icon events).
That triggers this bug. The slider at 100 and it unmuted is enough for my filtering to decide it try to set the volume to maximum.
Ideally I would like a special IDO signal for the mouse/icon click events. This would remove the need to subscribe to the value-changed signal resolving this bug.
Waiting on some feedback from Charles re the IDO signal...