Sound menu doesn't support absolute icon paths of desktop files

Bug #1024705 reported by Danillo on 2012-07-14
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Sound Menu
Fix Released
Medium
Unassigned
indicator-sound (Ubuntu)
Medium
Unassigned

Bug Description

Hi! I used MenuLibre to change gmusicbrowser's ugly default icon for a higher resolution one. All icons were successfully changes, included the alt+tab icon, but its icon in SoundMenu indicator was gone after the change. See attached screenshot.

I'm using Ubuntu 12.04 with Unity 5.12.0.

Related branches

Danillo (danillo) wrote :
Sean Davis (bluesabre) wrote :

Hello Danillo,

That is very unusual. Did you change the icon to a named icon or a filename? If it's a named icon, what icon theme are you using?

Danillo (danillo) wrote :

I changed it to the one in attached. Could this be because it's an svg? I also can't preview the icon sizes because they're all showing a question mark picture. I'm using the default ubuntu-mono-dark.

Sean Davis (bluesabre) wrote :

Hello Danillo,

It looks like this is a bug in indicator-sound. It's not getting the icon when it's set to a filename. I've changed the project and attached the modified gmusicbrowser.desktop.

As far as the icon size previews, is it failing for every icon or just this one?

affects: menulibre → indicator-sound
Danillo (danillo) wrote :

Thank you, sean! When I change the icon at first the previews are shown, but when I go to MenuLibre at a latter momment to check the icons are gone, replaced by question marks. It's happening with every icon.

Bilal Akhtar (bilalakhtar) wrote :

Where did you place that SVG file? Also, did you run gtk-update-icon-cache at the end to update the icon cache?

Changed in indicator-sound:
status: New → Incomplete
Sean Davis (bluesabre) wrote :

Good day Bilal,

The desktop entry is using an absolute path, as opposed to a named icon.

According to the FD.o Desktop Entry spec (http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html), absolute paths are supported as an icon name.

It appears that the sound menu indicator does not support the absolute icon path. As you can see in the attached gmusicbrowser.desktop file, it is referring to the absolute path of an icon (which does exist). However, when you set this, it works properly in the dash, Xfce menus and panels, but not the sound menu.

Bilal Akhtar (bilalakhtar) wrote :

Should be an easy fix then.

summary: - Gmusicbrowser icon in SoundMenu indicator gone after MenuLibre change
+ Sound menu doesn't support absolute icon paths of desktop files
Changed in indicator-sound:
importance: Undecided → Medium
status: Incomplete → Triaged
Changed in indicator-sound (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Albert Astals Cid (aacid) wrote :

I'll have a look

Changed in indicator-sound:
assignee: nobody → Albert Astals Cid (aacid)
status: Triaged → In Progress
Changed in indicator-sound:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-sound - 12.10.2daily12.11.21.1-0ubuntu1

---------------
indicator-sound (12.10.2daily12.11.21.1-0ubuntu1) raring; urgency=low

  [ Mathieu Trudel-Lapierre ]
  * debian/control:
    - add gnome-common to Build-Depends for use by dh_autoreconf.
    - update style for constency: use trailing commas at the end of dep lists.
    - Add Vcs-Bzr, Vcs-Browser fields with comment for uploaders.
  * debian/rules:
    - override dh_autoreconf to use autogen.sh for the reconfiguration process.
    - add export DPKG_GENSYMBOLS_CHECK_LEVEL=4.
    - enable quilt with the dh sequencer to make sure patches get applied.
  * debian/compat: bump to compat level 9.
  * debian/source/format: migrate back to source format 1.0 for consistency
    with the rest of the indicator stack.
  * Automatic snapshot from revision 337 (bootstrap):
    - Add 'check-news' to AM_INIT_AUTOMAKE. (LP: #1075753)
    - Remove the determine_key function. (LP: #1064255)
    - Use the file path directly if it's an absolute path. (LP: #1024705)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 339
 -- Automatic PS uploader <email address hidden> Wed, 21 Nov 2012 11:47:58 +0000

Changed in indicator-sound (Ubuntu):
status: Triaged → Fix Released
Changed in indicator-sound:
assignee: Albert Astals Cid (aacid) → nobody
Lars Karlitski (larsu) on 2014-04-11
Changed in indicator-sound:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers