indicator-session: ftbfs with gcc-4.6 -Werror

Bug #793105 reported by Evgeni Golov on 2011-06-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Session Menu
Fix Released
Low
Conor Curran
indicator-session (Debian)
Fix Released
Unknown

Bug Description

Quoting the original bug report (http://bugs.debian.org/625356):

This package builds with -Werror, and GCC 4.6 triggers new warnings
which will make the package fail to build. Currently a Debian patch
just passes
    -Wno-error=unused-but-set-variable and
    -Wno-error=unused-but-set-parameter
to avoid build failures, but this patch will be reverted with the
GCC 4.6.1 release, and the severity of the report will be raised.

The full build log can be found at:
http://people.debian.org/~doko/tmp/werror/indicator-session_0.2.15-1_lsid64.buildlog

The relevant lines in the log are:
users-service-dbus.c: In function 'seat_proxy_session_added':
users-service-dbus.c:589:18: warning: variable 'res' set but not used [-Wunused-but-set-variable]

The variable is really unused there. Either return res, or just ignore the return value of do_add_session completely.

Regards
Evgeni

Changed in indicator-session (Debian):
status: Unknown → New
Conor Curran (cjcurran) on 2011-08-11
Changed in indicator-session:
assignee: nobody → Conor Curran (cjcurran)
status: New → Triaged
importance: Undecided → Low
status: Triaged → In Progress
milestone: none → 0.3.2
Conor Curran (cjcurran) wrote :

I just checked trunk and it seemed this has been fixed but the bug has not been updated.
Marking upstream fix released, will consult with the previous maintainer before marking debian's bug resolved.

Changed in indicator-session:
status: In Progress → Fix Released
Changed in indicator-session (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.