Icon fallback code needed

Bug #1048348 reported by Andrew Gunnerson on 2012-09-09
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Session Menu
Fix Released
Low
Lars Karlitski
indicator-session (Ubuntu)
Low
Unassigned

Bug Description

Currently, indicator session does not have a fallback mechanism for the icon. If the GREETER_ICON_DEFAULT, GREETER_ICON_RESTART, ICON_DEFAULT, ICON_INFO, or ICON_ALERT icons are missing from the current icon theme, then the indicator menu gets hidden (need to blindly click to open it).

The session indicator needs to have some way to fallback to a standard icon in hicolor-icon-theme if a needed icon is missing from the current icon theme.

The attached patch addresses this issue (I'm not a good programmer, sorry :D). If a needed icon does not exist, it will fallback to the system-shutdown icon. It will also connect to the GtkIconTheme "changed" signal so that indicator_session_update_icon_and_a11y() is called again when the icon theme is changed.

Related branches

Andrew Gunnerson (cxl) wrote :
description: updated
Bilal Akhtar (bilalakhtar) wrote :

Could someone please review this patch? It looks good for me, but I'm not certain indicator-session is the right place to fix this (lightdm? indicator-applet?)

Changed in indicator-session:
status: New → Triaged
importance: Undecided → Low
Changed in indicator-session (Ubuntu):
status: New → Triaged
importance: Undecided → Low
tags: added: patch

The attachment "Add icon fallback mechanism" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Lars Karlitski (larsu) wrote :

Thanks for the patch, I've commited it in a branch and requested a merge.

Charles Kerr (charlesk) on 2012-09-13
Changed in indicator-session:
assignee: nobody → Lars Uebernickel (larsu)
milestone: none → 12.10.3
Changed in indicator-session:
status: Triaged → Fix Committed
Andrew Gunnerson (cxl) wrote :

Thanks for merging the patch! This was my first code contribution to any open-source software :)

Lars Karlitski (larsu) wrote :

Welcome aboard!

Charles Kerr (charlesk) on 2012-09-20
Changed in indicator-session:
status: Fix Committed → Fix Released
Charles Kerr (charlesk) on 2012-10-24
Changed in indicator-session (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers