unit test "DeviceTest.NewFromVariant" fails on armhf / powerpc
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
indicator-power |
Fix Released
|
Undecided
|
Charles Kerr | ||
indicator-power (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
As reported at <https:/
Running main() from gtest_main.cc
[==========] Running 8 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 8 tests from DeviceTest
[ RUN ] DeviceTest.
[ OK ] DeviceTest.
[ RUN ] DeviceTest.
[ OK ] DeviceTest.
[ RUN ] DeviceTest.New
[ OK ] DeviceTest.New (1 ms)
[ RUN ] DeviceTest.
test-device.cc:215: Failure
Value of: 30
Expected: indicator_
Which is: 1078832665
[ FAILED ] DeviceTest.
[ RUN ] DeviceTest.
[ OK ] DeviceTest.
[ RUN ] DeviceTest.
[ OK ] DeviceTest.
[ RUN ] DeviceTest.Labels
[ OK ] DeviceTest.Labels (1 ms)
[ RUN ] DeviceTest.
[ OK ] DeviceTest.
[----------] 8 tests from DeviceTest (48 ms total)
[----------] Global test environment tear-down
[==========] 8 tests from 1 test case ran. (56 ms total)
[ PASSED ] 7 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DeviceTest.
1 FAILED TEST
FAIL: test-device
Related branches
- Ted Gould (community): Approve
- Mathieu Trudel-Lapierre: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 19 lines (+4/-4)1 file modifiedtests/test-device.cc (+4/-4)
summary: |
- unit tests fail on armhf / powerpc + unit test DeviceTest.NewFromVariant fails on armhf / powerpc |
summary: |
- unit test DeviceTest.NewFromVariant fails on armhf / powerpc + unit test "DeviceTest.NewFromVariant" fails on armhf / powerpc |
Changed in indicator-power: | |
status: | In Progress → Fix Committed |
Changed in indicator-power: | |
status: | Fix Committed → Fix Released |
This looks like a garden-variety bug where we we're passing an integral value to a function, and need to explicitly cast it to the correct width because it's a varargs function.