indicator-power doesn't always choose the correct primary device
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
indicator-power |
Fix Released
|
Medium
|
Charles Kerr |
Bug Description
According to the https:/
> The menu title should tell you at a glance what you need to know most: what device will lose power soonest (and optionally when), or otherwise which device will take longest to charge (and optionally how long it will take). More detailed information can be accessed inside the menu itself.
But the following unit test fails:
> /* Both discharging, same charge %, different times left before empty.
> Confirm that the one with less time is chosen. */
> set_device_
> set_device_
> ASSERT_EQ (a, indicator_
Related branches
- Lars Karlitski (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 779 lines (+402/-233)5 files modifiedsrc/device.c (+18/-14)
src/indicator-power.c (+94/-71)
src/indicator-power.h (+2/-0)
tests/test-device.cc (+274/-148)
tests/test-indicator.cc (+14/-0)
Changed in indicator-power: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-power: | |
status: | In Progress → Fix Committed |
Changed in indicator-power: | |
status: | Fix Committed → Fix Released |
milestone: | none → 12.10.4 |