[system-settings] missing SIM unlock

[Olga Kemmet]

Build r91

1. set up a SIM PIN or make sure the inserted SIM has already a set up SIM PIN (reboot device if needed)
2. after reboot, don't unlock
3. navigate to System Settings > Security & Privacy > SIM PIN

What you see: A green tick on the toggle next to the SIM PIN and beneath that a "Change PIN..." button

What you should see: Some way to unlock the SIM without turning off the SIM PIN.

There are three relevant states for a SIM:
(A) no SIM PIN set
(B) SIM PIN set, SIM locked
(C) SIM PIN set, SIM unlocked.

If a SIM PIN is set, when you start up the phone you have the choice to unlock it (switch from B to C) or not (stay on B).

If you don't unlock it, you can't make or receive calls, send or receive SMS, or use cellular data in any app. And you probably can't predict ahead of time whether you'll want to do any of those things.

Currently System Settings only lets you turn the SIM PIN on (A to C) or off (C to A), not to unlock it. System Settings should let you do this too.

<https://wiki.ubuntu.com/SecurityAndPrivacySettings#sim-pin>: "Whenever it is locked, at the trailing end should be an 'Unlock…' button..."

[Michał Sawicz (saviq)]

I don't see unity8 to have anything to do here, it's just that settings need to trigger the SIM unlock mechanism.

[Olga Kemmet (olga-kemmet)]

@Michal: I wasn't sure which project was the corresponding one to this bug. Please feel free to remove it, if it doesn't affect Unity8.

[Michał Sawicz (saviq)]

Yeah, that's fine, left it be for now in case we decide there actually is something we need to do here.

[Tony Espy (awe)]

Correct me if I'm wrong, but I was always under the assumption that we were going to add automatic SIM PIN unlock prompting on boot and after Flight-Mode is disabled.

What I'm not sure of is whether this new PIN prompting will allow a user to skip entering the PIN? On Android, this isn't allowed. I'm not sure about the behavior of iOS.

Anyways, if we don't allow the user to skip entering the PIN, then there's no need for an unlock function on this screen is there?

[Michał Sawicz (saviq)]

W dniu 09.10.2014 o 22:13, Tony Espy pisze:
> Correct me if I'm wrong, but I was always under the assumption that we
> were going to add automatic SIM PIN unlock prompting on boot and after
> Flight-Mode is disabled.

That we will, soon.

> What I'm not sure of is whether this new PIN prompting will allow a user
> to skip entering the PIN? On Android, this isn't allowed. I'm not sure
> about the behavior of iOS.

Yes, you'll be able to skip it. Making it required feels weird as...
just take the SIM out to bypass it ;)

[Antti Kaijanmäki (kaijanmaki)]

@awe:
Yes, the automatic prompting will be there during the boot (flightmode not scheduled yet, might be ota):
https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1333121

I discussed with Olga today and we will allow the user to skip entering the SIM PIN.

[Pat McGowan (pat-mcgowan)]

We recently made a fix to ofono so that the user only enters the PIN once in the settings view, and it both unlocks and performs the requested action, which is what mako was already doing.
If I understand the bug correctly it is no longer valid.

[Matthew Paul Thomas (mpt)]

Specification updated. <https://wiki.ubuntu.com/SecurityAndPrivacySettings?action=diff&rev2=52&rev1=51>

[Pat McGowan (pat-mcgowan)]

The ability to unlock the SIM is already available in the network indicator, and a SIM with a lock icon is displayed.. Just to clarify the point about each app needing its own support for this, that is already not the case. So you are saying we want to also expose this functionality in settings

Note that currently when the user wants to disable the SIM pin or change it, we prompt once for the current PIN and unlock as needed for those actions.

[Olga Kemmet (olga-kemmet)]

@Pat Unlocking the SIM from any app is unnecessary. What we said though is that the unlocking prompt should at least happen in the phone and messaging app on action and that for a later release. E.g. if a user is trying to make a phone call and taps the call button, the unlock prompt will appear. User still can dismiss this step. Currently user is redirected to system settings to unlock the SIM.

[Pat McGowan (pat-mcgowan)]

"Currently user is redirected to system settings to unlock the SIM"
I think I now understand the root of the issue :)
Luckily it also mentions the indicator, but its unfortunate the message points them to a nonexistent option.

[Pat McGowan (pat-mcgowan)]

With the proposed design, to change the pin when locked the user will need to enter the pin first to unlock, then again when changing the pin. Today the user only enters the current PIn once to change PIN irrespective of whether it is locked or not.
Can we decouple unlock from change pin?

[Matthew Paul Thomas (mpt)]

I was mistaken in suggesting the alternative to unlocking at startup was unlocking prompted by individual apps, for two reasons. First, it is indeed present in the network menu. (For that reason, this probably isn't Critical.) And second, we could have an OS-provided unlock prompt whenever an app tries to access SIM functions when the SIM is locked, without the app having any special knowledge of this -- in the same way as the OS prompts when an app wants to access your photos, or (once bug 1275761 is fixed) when an app tries to use the Internet.

Furthermore, that the current error dialog currently directs you to System Settings does not mean that SIM unlock *should* be in System Settings. We could just fix the error dialog -- though directing you to "the network indicator at the top of the screen" is a bit hand-wavy.

There's a more mundane reason to access SIM unlocking from System Settings. As long as you can use the phone with the SIM locked, it is weird for System Settings to have a "SIM PIN" screen that lets you turn the SIM PIN on or off altogether, but does not let you simply unlock it.

I think it's fine for changing the PIN to require unlocking first, because I think you're unlikely to want to do them consecutively.

[Jonas G. Drange (jonas-drange)]

This bug requires bug 1374082 to be fixed.

[Ken VanDine (ken-vandine)]

@mpt, I'm unclear in your comment #13 if you mean we should add a prompt for EnterPin as well as UnlockPin or if what we have now is enough? system-settings doesn't actually do anything with the SIM that requires it to be unlocked, but it does allow enabling or disabling locking, which we already provide the prompt for PIN.

[Matthew Paul Thomas (mpt)]

I'm sorry I don't know what "add a prompt for EnterPin" means.

I would be surprised if call forwarding and call waiting ("Phone" category) could be changed with the SIM locked. But whether System Settings itself requires the SIM to be unlocked isn't relevant. (Those functions could trigger a system-provided on-demand PIN prompt just like everything else could.) As I said, the reason System Settings should include the ability to unlock the SIM is that it would be strange for System Settings to include the ability to do everything with the SIM PIN *except* unlocking it.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20150129.2-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20150129.2-0ubuntu1) vivid; urgency=low

  [ Ken VanDine ]
  * initialize m_lastFullCharge as NULL

  [ Sebastien Bacher ]
  * [sound] tweak strings following design recommendation (LP: #1410766)
  * [security-privacy] enable the confirmation button only in the cases
    described by the specification (LP: #1412523, #1412527)

  [ jonas-drange ]
  * [security/privacy] add connectivity binding and let user unlock a
    given SIM (LP: #1378883)
 -- Ubuntu daily release <email address hidden> Thu, 29 Jan 2015 18:32:13 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20150204~rtm-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20150204~rtm-0ubuntu1) 14.09; urgency=medium

  [ Ken VanDine ]
  * Revoke any cached authorizations before trying to change password
    mode. This makes sure that we authenticate the user again even if we
    just did so (for UX consistency).
  * [about] properly display IMEI values for no devices ("None"), one
    device and multiple devices. Remove test now redundant. (LP:
    #1205294)
  * [security/privacy] add connectivity binding and let user unlock a
    given SIM (LP: #1378883)
 -- Ubuntu daily release <email address hidden> Wed, 04 Feb 2015 17:38:10 +0000

[Matthew Paul Thomas (mpt)]

I can't test this because I do not have a SIM with a known PIN.

[Olga Kemmet (olga-kemmet)]

Marking as fix released: tested on 15.04, r113