SIM unlock doesn't accept 5 digits PIN
Bug #1240561 reported by
Loïc Minier
This bug affects 5 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Network Menu |
Fix Released
|
Undecided
|
Antti Kaijanmäki | ||
indicator-network (Ubuntu) |
Fix Released
|
Undecided
|
Antti Kaijanmäki | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Michael Zanetti |
Bug Description
My SIM unlock PIN is 5 digits; when I type the 4th one, it's immediately sent to the SIM.
I haven't retried since I fear locking it for good.
I have seen some code allowing up to 16 digits for SIM PIN and a couple of docs mentioning 8 digits for SIM PIN and PUK.
I think we should allow 8 digits.
<https:/
Related branches
lp:~mzanetti/unity8/sim-pin-variable-length
- PS Jenkins bot (community): Approve (continuous-integration)
- Mirco Müller (community): Approve
-
Diff: 239 lines (+118/-28)4 files modifiedComponents/PinPadButton.qml (+42/-15)
Greeter/PinLockscreen.qml (+34/-4)
Notifications/NotificationMenuItemFactory.qml (+0/-5)
tests/qmltests/Greeter/tst_Lockscreen.qml (+42/-4)
lp:~unity-api-team/indicator-network/indicator-network-cpp
- Jussi Pakkanen (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 21218 lines (+16387/-4059)114 files modified.bzrignore (+3/-12)
CMakeLists.txt (+21/-5)
cmake/FindVala.cmake (+0/-57)
cmake/UseVala.cmake (+0/-241)
config.h.in (+0/-1)
data/com.canonical.indicator.network (+22/-2)
data/indicator-network.conf.in (+4/-1)
debian/control (+17/-1)
debian/indicator-network-autopilot.install (+2/-0)
debian/indicator-network.install (+8/-0)
debian/rules (+16/-3)
network/CMakeLists.txt (+57/-180)
network/action-muxer.c (+0/-501)
network/action-muxer.h (+0/-47)
network/action-muxer.vapi (+0/-10)
network/config.vapi (+0/-8)
network/dbus-cpp/services/ofono.h (+1322/-0)
network/device-base.vala (+0/-245)
network/device-ethernet.vala (+0/-64)
network/device-mobile.vala (+0/-166)
network/device-wifi.vala (+0/-578)
network/glib.supp (+141/-0)
network/indicator-menu.h (+99/-0)
network/indicator-network-service.cpp (+99/-0)
network/menuitems/access-point-item.h (+128/-0)
network/menuitems/item.h (+60/-0)
network/menuitems/section.h (+39/-0)
network/menuitems/switch-item.h (+80/-0)
network/menuitems/text-item.h (+72/-0)
network/menumodel-cpp/CMakeLists.txt (+32/-0)
network/menumodel-cpp/action-group-exporter.h (+93/-0)
network/menumodel-cpp/action-group-merger.h (+147/-0)
network/menumodel-cpp/action-group.h (+92/-0)
network/menumodel-cpp/action.cpp (+129/-0)
network/menumodel-cpp/action.h (+76/-0)
network/menumodel-cpp/gio-helpers/util.cpp (+55/-0)
network/menumodel-cpp/gio-helpers/util.h (+250/-0)
network/menumodel-cpp/gio-helpers/variant.h (+235/-0)
network/menumodel-cpp/menu-exporter.h (+63/-0)
network/menumodel-cpp/menu-item.h (+162/-0)
network/menumodel-cpp/menu-merger.h (+135/-0)
network/menumodel-cpp/menu-model.h (+31/-0)
network/menumodel-cpp/menu.h (+213/-0)
network/mobile-sim-manager.vala (+0/-545)
network/modem-manager.cpp (+194/-0)
network/modem-manager.h (+45/-0)
network/modem.cpp (+289/-0)
network/modem.h (+86/-0)
network/network-action-manager.vala (+0/-654)
network/network-menu-service.vala (+0/-43)
network/network-menu.vala (+0/-283)
network/notify-cpp/notification.cpp (+135/-0)
network/notify-cpp/notification.h (+65/-0)
network/notify-cpp/snapdecision/sim-unlock.cpp (+233/-0)
network/notify-cpp/snapdecision/sim-unlock.h (+78/-0)
network/ofono.vala (+0/-59)
network/quick-access-section.cpp (+96/-0)
network/quick-access-section.h (+41/-0)
network/root-state.cpp (+370/-0)
network/root-state.h (+43/-0)
network/run_valgrind.sh (+5/-0)
network/service.h (+151/-0)
network/settings-airplane.vala (+0/-45)
network/settings-base.vala (+0/-98)
network/settings-wifi.vala (+0/-52)
network/sim-unlock-dialog.cpp (+465/-0)
network/sim-unlock-dialog.h (+60/-0)
network/url-dispatcher-cpp/url-dispatcher.cpp (+44/-0)
network/url-dispatcher-cpp/url-dispatcher.h (+32/-0)
network/url-dispatcher.vapi (+0/-5)
network/util-wrapper.c (+0/-30)
network/util-wrapper.h (+0/-20)
network/util-wrapper.vapi (+0/-5)
network/utils.vala (+0/-23)
network/wifi-link-item.h (+251/-0)
network/wifi-section.cpp (+101/-0)
network/wifi-section.h (+45/-0)
network/wifi-settings.h (+37/-0)
network/wired-link.h (+34/-0)
network/wwan-link-item.cpp (+1019/-0)
network/wwan-link-item.h (+43/-0)
network/wwan-section.cpp (+149/-0)
network/wwan-section.h (+41/-0)
po/POTFILES.in (+0/-11)
po/POTFILES.skip (+0/-11)
secret-agent/PasswordMenu.cpp (+1/-0)
secret-agent/SecretAgent.cpp (+6/-0)
secret-agent/SecretRequest.cpp (+2/-0)
tests/CMakeLists.txt (+5/-51)
tests/autopilot/CMakeLists.txt (+8/-0)
tests/autopilot/README (+8/-0)
tests/autopilot/indicator_network/__init__.py (+17/-0)
tests/autopilot/indicator_network/data/pin-unlock.xml (+3677/-0)
tests/autopilot/indicator_network/helpers/phonesim_manager.py (+94/-0)
tests/autopilot/indicator_network/tests/__init__.py (+17/-0)
tests/autopilot/indicator_network/tests/test_unlock_sim.py (+143/-0)
tests/autopilot/setup.py (+32/-0)
tests/data/CMakeLists.txt (+4/-0)
tests/data/phonesim/pin-unlock.xml (+3677/-0)
tests/integration/CMakeLists.txt (+34/-0)
tests/unit/CMakeLists.txt (+2/-0)
tests/unit/network/CMakeLists.txt (+5/-0)
tests/unit/network/menuitems/CMakeLists.txt (+35/-0)
tests/unit/network/menuitems/test-access-point-item.cpp (+91/-0)
tests/unit/network/menuitems/test-switch-item.cpp (+65/-0)
tests/unit/network/menumodel-cpp/CMakeLists.txt (+34/-0)
tests/unit/network/menumodel-cpp/test-menu-exporter.cpp (+188/-0)
tests/unit/secret-agent/CMakeLists.txt (+50/-0)
tests/unit/secret-agent/TestSecretAgent.cpp (+4/-0)
tests/unit/test_variant.h (+14/-0)
tests/utils/CMakeLists.txt (+14/-0)
tests/utils/action-utils.cpp (+65/-0)
tests/utils/action-utils.h (+40/-0)
tests/utils/main.cpp (+0/-2)
Changed in unity8: | |
assignee: | nobody → Michael Zanetti (mzanetti) |
status: | New → In Progress |
importance: | Undecided → High |
tags: | added: has-test |
Changed in indicator-network: | |
status: | New → Confirmed |
Changed in unity8 (Ubuntu): | |
status: | New → Fix Committed |
Changed in unity8: | |
status: | Fix Committed → Fix Released |
description: | updated |
Changed in indicator-network: | |
assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
Changed in indicator-network (Ubuntu): | |
assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
Changed in indicator-network: | |
status: | Confirmed → Triaged |
Changed in indicator-network (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in indicator-network (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in indicator-network: | |
status: | Triaged → Fix Released |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Michael Zanetti (mzanetti) |
importance: | Undecided → High |
no longer affects: | unity8 |
To post a comment you must log in.
Just to confirm, GSM allows PINs to be 4-8 digits long.