Network Menu

Network menu shows WiFi networks even the switch is off

Bug #1226197 reported by Omer Akram on 2013-09-16

This bug affects 5 people

Affects		Status	Importance	Assigned to	Milestone
	Network Menu	Fix Released	High	Antti Kaijanmäki
	indicator-network (Ubuntu)	Fix Released	High	Antti Kaijanmäki

Bug Description

I reboot my phone and the network menu shows wireless networks even though the wifi switch indicates that its disabled. I have attached a screenshot. Its pretty easily reproducible here.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: indicator-network 0.5.0+13.10.20130913-0ubuntu1
Uname: Linux 3.4.0-3-mako armv7l
ApportVersion: 2.12.1-0ubuntu4
Architecture: armhf
Date: Mon Sep 16 18:43:04 2013
InstallationDate: Installed on 2013-09-14 (1 days ago)
InstallationMedia: Ubuntu Saucy Salamander (development branch) - armhf (20130914.1)
MarkForUpload: True
ProcEnviron:
TERM=linux
PATH=(custom, no user)
SourcePackage: indicator-network
UpgradeStatus: No upgrade log present (probably fresh install)

Tags:

Related branches

lp:~unity-api-team/indicator-network/indicator-network-cpp

Merged into lp:indicator-network/14.10 at revision 328

Jussi Pakkanen (community): Approve on 2014-05-08

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2014-05-08

Diff: 21218 lines (+16387/-4059)

114 files modified

.bzrignore (+3/-12)
CMakeLists.txt (+21/-5)
cmake/FindVala.cmake (+0/-57)
cmake/UseVala.cmake (+0/-241)
config.h.in (+0/-1)
data/com.canonical.indicator.network (+22/-2)
data/indicator-network.conf.in (+4/-1)
debian/control (+17/-1)
debian/indicator-network-autopilot.install (+2/-0)
debian/indicator-network.install (+8/-0)
debian/rules (+16/-3)
network/CMakeLists.txt (+57/-180)
network/action-muxer.c (+0/-501)
network/action-muxer.h (+0/-47)
network/action-muxer.vapi (+0/-10)
network/config.vapi (+0/-8)
network/dbus-cpp/services/ofono.h (+1322/-0)
network/device-base.vala (+0/-245)
network/device-ethernet.vala (+0/-64)
network/device-mobile.vala (+0/-166)
network/device-wifi.vala (+0/-578)
network/glib.supp (+141/-0)
network/indicator-menu.h (+99/-0)
network/indicator-network-service.cpp (+99/-0)
network/menuitems/access-point-item.h (+128/-0)
network/menuitems/item.h (+60/-0)
network/menuitems/section.h (+39/-0)
network/menuitems/switch-item.h (+80/-0)
network/menuitems/text-item.h (+72/-0)
network/menumodel-cpp/CMakeLists.txt (+32/-0)
network/menumodel-cpp/action-group-exporter.h (+93/-0)
network/menumodel-cpp/action-group-merger.h (+147/-0)
network/menumodel-cpp/action-group.h (+92/-0)
network/menumodel-cpp/action.cpp (+129/-0)
network/menumodel-cpp/action.h (+76/-0)
network/menumodel-cpp/gio-helpers/util.cpp (+55/-0)
network/menumodel-cpp/gio-helpers/util.h (+250/-0)
network/menumodel-cpp/gio-helpers/variant.h (+235/-0)
network/menumodel-cpp/menu-exporter.h (+63/-0)
network/menumodel-cpp/menu-item.h (+162/-0)
network/menumodel-cpp/menu-merger.h (+135/-0)
network/menumodel-cpp/menu-model.h (+31/-0)
network/menumodel-cpp/menu.h (+213/-0)
network/mobile-sim-manager.vala (+0/-545)
network/modem-manager.cpp (+194/-0)
network/modem-manager.h (+45/-0)
network/modem.cpp (+289/-0)
network/modem.h (+86/-0)
network/network-action-manager.vala (+0/-654)
network/network-menu-service.vala (+0/-43)
network/network-menu.vala (+0/-283)
network/notify-cpp/notification.cpp (+135/-0)
network/notify-cpp/notification.h (+65/-0)
network/notify-cpp/snapdecision/sim-unlock.cpp (+233/-0)
network/notify-cpp/snapdecision/sim-unlock.h (+78/-0)
network/ofono.vala (+0/-59)
network/quick-access-section.cpp (+96/-0)
network/quick-access-section.h (+41/-0)
network/root-state.cpp (+370/-0)
network/root-state.h (+43/-0)
network/run_valgrind.sh (+5/-0)
network/service.h (+151/-0)
network/settings-airplane.vala (+0/-45)
network/settings-base.vala (+0/-98)
network/settings-wifi.vala (+0/-52)
network/sim-unlock-dialog.cpp (+465/-0)
network/sim-unlock-dialog.h (+60/-0)
network/url-dispatcher-cpp/url-dispatcher.cpp (+44/-0)
network/url-dispatcher-cpp/url-dispatcher.h (+32/-0)
network/url-dispatcher.vapi (+0/-5)
network/util-wrapper.c (+0/-30)
network/util-wrapper.h (+0/-20)
network/util-wrapper.vapi (+0/-5)
network/utils.vala (+0/-23)
network/wifi-link-item.h (+251/-0)
network/wifi-section.cpp (+101/-0)
network/wifi-section.h (+45/-0)
network/wifi-settings.h (+37/-0)
network/wired-link.h (+34/-0)
network/wwan-link-item.cpp (+1019/-0)
network/wwan-link-item.h (+43/-0)
network/wwan-section.cpp (+149/-0)
network/wwan-section.h (+41/-0)
po/POTFILES.in (+0/-11)
po/POTFILES.skip (+0/-11)
secret-agent/PasswordMenu.cpp (+1/-0)
secret-agent/SecretAgent.cpp (+6/-0)
secret-agent/SecretRequest.cpp (+2/-0)
tests/CMakeLists.txt (+5/-51)
tests/autopilot/CMakeLists.txt (+8/-0)
tests/autopilot/README (+8/-0)
tests/autopilot/indicator_network/__init__.py (+17/-0)
tests/autopilot/indicator_network/data/pin-unlock.xml (+3677/-0)
tests/autopilot/indicator_network/helpers/phonesim_manager.py (+94/-0)
tests/autopilot/indicator_network/tests/__init__.py (+17/-0)
tests/autopilot/indicator_network/tests/test_unlock_sim.py (+143/-0)
tests/autopilot/setup.py (+32/-0)
tests/data/CMakeLists.txt (+4/-0)
tests/data/phonesim/pin-unlock.xml (+3677/-0)
tests/integration/CMakeLists.txt (+34/-0)
tests/unit/CMakeLists.txt (+2/-0)
tests/unit/network/CMakeLists.txt (+5/-0)
tests/unit/network/menuitems/CMakeLists.txt (+35/-0)
tests/unit/network/menuitems/test-access-point-item.cpp (+91/-0)
tests/unit/network/menuitems/test-switch-item.cpp (+65/-0)
tests/unit/network/menumodel-cpp/CMakeLists.txt (+34/-0)
tests/unit/network/menumodel-cpp/test-menu-exporter.cpp (+188/-0)
tests/unit/secret-agent/CMakeLists.txt (+50/-0)
tests/unit/secret-agent/TestSecretAgent.cpp (+4/-0)
tests/unit/test_variant.h (+14/-0)
tests/utils/CMakeLists.txt (+14/-0)
tests/utils/action-utils.cpp (+65/-0)
tests/utils/action-utils.h (+40/-0)
tests/utils/main.cpp (+0/-2)

Revision history for this message

Omer Akram (om26er) wrote on 2013-09-16:

screenshot_1379356999.png Edit (58.5 KiB, image/png)
Dependencies.txt Edit (4.1 KiB, text/plain; charset="utf-8")
HookError_source_indicator_network.txt Edit (339 bytes, text/plain; charset="utf-8")

tags:	added: avengers
summary:	- Network menu shows wireless networks even the switch is off + Network menu shows WiFi networks even the switch is off

Nicholas Skaggs (nskaggs) on 2013-09-16

Changed in indicator-network:
status:	New → Confirmed
Changed in indicator-network (Ubuntu):
status:	New → Confirmed

Julien Funk (jaboing) on 2013-09-16

Changed in indicator-network (Ubuntu):
importance:	Undecided → Medium

Omer Akram (om26er) on 2013-09-16

Changed in indicator-network:
importance:	Undecided → Medium

Thomas Strehl (strehl-t) on 2013-10-02

Changed in indicator-network (Ubuntu):
assignee:	nobody → Ted Gould (ted)

Thomas Strehl (strehl-t) on 2013-10-04

Changed in indicator-network:
importance:	Medium → High
Changed in indicator-network (Ubuntu):
importance:	Medium → High

Revision history for this message

Ted Gould (ted) wrote on 2013-10-04:

I can't reproduce this on the Galaxy Nexus, and it seems to only be happening on the N4. Reassigning to Network Manager as it needs to move further down the stack. Guessing the Wifi driver isn't getting disabled when NM asks it to.

affects:	indicator-network (Ubuntu) → network-manager (Ubuntu)
Changed in network-manager (Ubuntu):
assignee:	Ted Gould (ted) → Mathieu Trudel-Lapierre (mathieu-tl)
Changed in indicator-network:
status:	Confirmed → Incomplete

Revision history for this message

Omer Akram (om26er) wrote on 2013-10-07:

The problem is only seen after a clean flash of the device.

Allan LeSage (allanlesage) on 2013-10-15

tags:

added: qa-touch

Revision history for this message

Allan LeSage (allanlesage) wrote on 2013-10-15:

So I'm able to reproduce this by turning off/on/off Wi-Fi under System Settings; that menu is left in a state with APs remaining--then navigating to the indicator will show those remaining networks. (I.e. shutdown/startup may not be implicated.)

Revision history for this message

Tony Espy (awe) wrote on 2013-10-15:

Ted and I discussed earlier and I'd assumed this was the same as bug #1220332. I'm now convinced they're different bugs.

I tested this on maguro with image #98 + the indicator-network package from the merge associated with bug #1220332.

After booting the phone, the toggle shows that Wi-Fi is on ( which is actually the wrong, Wi-Fi should be *off* by default, but that's another bug ). Toggling the control off works correctly and all networks are cleared from the menu. Toggling the control back on causes networks to appear again in the list, however immediately the switch toggles from on to off, and we're now in the state originally described ( networks appear when Wi-Fi toggle is off ). At this point, I checked the state of the NM properties, and WirelessEnabled and WirelessHardwareEnabled are both set to "true".

Revision history for this message

Tony Espy (awe) wrote on 2013-10-15:

Actually, so based on my last comment, I believe this is an indicator-network bug, not a network manager bug.

Revision history for this message

Antti Kaijanmäki (kaijanmaki) wrote on 2013-10-16:

OK, so. the wifi-enabled switch needs a bit love. Currently it gets it's state changed when NM sends wifi-enabled signal, but also when wifi device changes state.

Tony Espy (awe) on 2013-10-16

affects:	network-manager (Ubuntu) → indicator-network (Ubuntu)
Changed in indicator-network (Ubuntu):
assignee:	Mathieu Trudel-Lapierre (mathieu-tl) → nobody

Revision history for this message

Tony Espy (awe) wrote on 2013-10-29:

Just confirmed the behavior described in comment #5 using image #100. The state is correct on 1st boot, but toggling Wi-Fi off, then back on again reproduces the bug.

Antti Kaijanmäki (kaijanmaki) on 2014-04-03

Changed in indicator-network (Ubuntu):
assignee:	nobody → Antti Kaijanmäki (kaijanmaki)
Changed in indicator-network:
assignee:	nobody → Antti Kaijanmäki (kaijanmaki)