Emesene needs the offline status to be different from invisible
Bug #817504 reported by
Sven Baars
on 2011-07-28
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Messaging Menu |
Fix Released
|
Undecided
|
Unassigned | |
| 0.5 |
Fix Released
|
Undecided
|
Unassigned | |
| emesene |
Fix Released
|
Medium
|
Sven Baars |
Bug Description
Expected behavior for emesene would be that clicking offline in the memenu would disconnect emesene and setting invisible would set the invisible status. Atm they're the same and therefore the attached patch changes the offline status to invisible (for backward compatibility) and adds a new status that we can use to disconnect.
Related branches
lp:~indicator-applet-developers/indicator-messages/ubuntu
- Ken VanDine: Pending requested 2011-09-28
-
Diff: 174 lines (+27/-55)8 files modifiedAUTHORS (+1/-0)
ChangeLog (+12/-0)
configure (+1/-1)
configure.ac (+1/-1)
debian/changelog (+8/-0)
debian/patches/lp_690668.patch (+0/-44)
debian/patches/series (+0/-1)
src/indicator-messages.c (+4/-8)
Sven Baars (sbte) wrote : | #1 |
Changed in emesene: | |
assignee: | nobody → sbte (sbte) |
importance: | Undecided → Medium |
Sven Baars (sbte) wrote : | #2 |
Marco Trevisan (Treviño) (3v1n0) wrote : | #3 |
I'd suggest you to make a branch ed ask for merge request.
bzr branch lp:indicator-messages
cd indicator-
patch -p0 < invisible-
bzr commit -m "Change OFFLINE to INVISIBLE and add a new OFFLINE status"
bzr push lp:~sbte/indicator-messages/fix-817504
Then ask for merge on the branch page ;)
Sven Baars (sbte) wrote : | #4 |
Done. Thanks for the guide.
Sven Baars (sbte)
on 2011-08-05
Changed in emesene: | |
status: | New → In Progress |
Ted Gould (ted)
on 2011-08-18
Changed in indicator-messages: | |
status: | Fix Committed → Fix Released |
Sven Baars (sbte)
on 2011-08-19
Changed in emesene: | |
status: | In Progress → Fix Committed |
Sven Baars (sbte)
on 2011-10-08
Changed in emesene: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Forgot to add, if someone could merge this, that would be great. I'll commit a fix to support this in emesene right now. The next release of emesene will be in a few days, so hopefully this will work out of the box in the 11.10 release.