Emesene needs the offline status to be different from invisible

Bug #817504 reported by Sven Baars on 2011-07-28
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Messaging Menu
Fix Released
Undecided
Unassigned
0.5
Fix Released
Undecided
Unassigned
emesene
Fix Released
Medium
Sven Baars

Bug Description

Expected behavior for emesene would be that clicking offline in the memenu would disconnect emesene and setting invisible would set the invisible status. Atm they're the same and therefore the attached patch changes the offline status to invisible (for backward compatibility) and adds a new status that we can use to disconnect.

Related branches

Sven Baars (sbte) wrote :
Changed in emesene:
assignee: nobody → sbte (sbte)
importance: Undecided → Medium
Sven Baars (sbte) wrote :

Forgot to add, if someone could merge this, that would be great. I'll commit a fix to support this in emesene right now. The next release of emesene will be in a few days, so hopefully this will work out of the box in the 11.10 release.

I'd suggest you to make a branch ed ask for merge request.

 bzr branch lp:indicator-messages
 cd indicator-messages/src
 patch -p0 < invisible-status-fix.diff
 bzr commit -m "Change OFFLINE to INVISIBLE and add a new OFFLINE status"
 bzr push lp:~sbte/indicator-messages/fix-817504

Then ask for merge on the branch page ;)

Sven Baars (sbte) wrote :

Done. Thanks for the guide.

Sven Baars (sbte) on 2011-08-05
Changed in emesene:
status: New → In Progress
Ted Gould (ted) on 2011-08-18
Changed in indicator-messages:
status: Fix Committed → Fix Released
Sven Baars (sbte) on 2011-08-19
Changed in emesene:
status: In Progress → Fix Committed
Sven Baars (sbte) on 2011-10-08
Changed in emesene:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers