libindicate, libdbusmenu, indicator-messages-service memleaks

[Chow Loong Jin]

  affects libindicate
  affects dbusmenu
  affects indicator-messages

As per the title, these projects leak memory. dbus_g_proxy_end_call requires you
to free the memory it allocates, including the GErrors. The patch attached does
that.

indicator-messages has an additional leak, which I'm not sure is libdbusmenu's
or indicator-messages' fault. libdbusmenu passes a GdkPixbuf into
indicator-messages, indicator-messages scales it and doesn't free the original
pixbuf. However, libdbusmenu doesn't free those pixbufs either, so it gets
leaked. The same thing happened with indicator-sound, but the patch for that has
already been committed.

These patches are by no means complete. I'm just hunting down memleaks one by
one using Valgrind's massif, and targeting functions that allocate too much memory.

--
Kind regards,
Loong Jin

[Chow Loong Jin (hyperair)]

Updated dbusmenu and libindicate patches to free GValues as well. I think the dbusmenu one is particularly prominent -- the GHashTable doesn't free the GValue for you if you don't give it a freeing function.

[Alex Launi (alexlauni)]

The dbusmenu patch no longer applies, libindicate seems to have been fixed already. Indicator messages still looks useful though. I will ping Ted to give it a more thorough reviewing.

[Ted Gould (ted)]

The dbusmenu one didn't apply, but I went through and tried to get the heart of the changes. I pushed that into this branch:

  lp:~ted/dbusmenu/mem-leaks

I also adapted the libindicate patch and pushed it here:

  lp:~ted/libindicate/mem-leak

And the indicator messages one applied cleanly (with fuzz):

  lp:~ted/indicator-messages/mem-leaks