Messaging menu does not change icon when a new message appears
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Messaging Menu |
Fix Released
|
Undecided
|
Lars Karlitski | |
| indicator-messages (Ubuntu) |
High
|
Lars Karlitski | ||
| Saucy |
High
|
Lars Karlitski | ||
| unity8 (Ubuntu) |
High
|
Nick Dedekind | ||
| Saucy |
High
|
Nick Dedekind |
Bug Description
I just pulled indicator-messages from trunk (bzr360) and installed it on the phone and rebooted. Now when a new message appears, I get the OSD notification and when I open the messaging menu there is indeed a pending sms there but The color of the messaging menu did not change. See the attached screenshot.
Related branches
- Ted Gould (community): Approve on 2013-08-29
- PS Jenkins bot (community): Approve (continuous-integration) on 2013-08-29
-
Diff: 20 lines (+2/-1)1 file modifiedlibmessaging-menu/messaging-menu-message.c (+2/-1)
- PS Jenkins bot (community): Approve (continuous-integration) on 2013-09-26
- Michael Zanetti (community): Approve on 2013-09-26
-
Diff: 1100 lines (+336/-214)25 files modifiedPanel/IndicatorsDataModel.qml (+2/-2)
debian/unity8.install (+0/-1)
plugins/Unity/Indicators/CMakeLists.txt (+1/-0)
plugins/Unity/Indicators/Messaging/qml/ActionTextField.qml (+10/-7)
plugins/Unity/Indicators/Messaging/qml/CMakeLists.txt (+1/-1)
plugins/Unity/Indicators/Messaging/qml/GroupedMessage.qml (+14/-19)
plugins/Unity/Indicators/Messaging/qml/HeroMessage.qml (+25/-22)
plugins/Unity/Indicators/Messaging/qml/MessageMenuItemFactory.qml (+117/-33)
plugins/Unity/Indicators/Messaging/qml/QuickReply.qml (+10/-5)
plugins/Unity/Indicators/Messaging/qml/SimpleTextMessage.qml (+7/-4)
plugins/Unity/Indicators/Messaging/qml/SnapDecision.qml (+33/-14)
plugins/Unity/Indicators/Messaging/qml/TextMessage.qml (+13/-5)
plugins/Unity/Indicators/Messaging/qml/qmldir (+2/-2)
plugins/Unity/Indicators/plugin.cpp (+2/-0)
plugins/Unity/Indicators/qml/BaseMenuItem.qml (+1/-1)
plugins/Unity/Indicators/qml/IndicatorPage.qml (+33/-6)
plugins/Unity/Indicators/qml/MenuItemFactory.qml (+62/-12)
plugins/Unity/Indicators/resources/indicators.qrc (+3/-0)
plugins/Unity/IndicatorsLegacy/CMakeLists.txt (+0/-1)
plugins/Unity/IndicatorsLegacy/Messaging/qml/ActionButton.qml (+0/-43)
plugins/Unity/IndicatorsLegacy/qml/MenuItemFactory.qml (+0/-8)
plugins/Unity/IndicatorsLegacy/resources/indicators.qrc (+0/-3)
src/Panel/Indicators/CMakeLists.txt (+0/-1)
src/Panel/Indicators/servicefiles/CMakeLists.txt (+0/-14)
src/Panel/Indicators/servicefiles/com.canonical.indicator.messages (+0/-10)
- Ted Gould (community): Approve on 2013-10-04
- PS Jenkins bot (community): Approve (continuous-integration) on 2013-10-04
-
Diff: 215 lines (+55/-40)2 files modifiedsrc/im-application-list.c (+52/-39)
src/im-desktop-menu.c (+3/-1)
Omer Akram (om26er) wrote : | #1 |
Lars Karlitski (larsu) wrote : | #2 |
no longer affects: | ubuntu |
Changed in indicator-messages: | |
status: | New → In Progress |
Changed in indicator-messages (Ubuntu): | |
status: | New → Confirmed |
Changed in indicator-messages: | |
assignee: | nobody → Lars Uebernickel (larsu) |
PS Jenkins bot (ps-jenkins) wrote : | #3 |
Fix committed into lp:indicator-messages at revision 372, scheduled for release in indicator-messages, milestone 13.10.0
Changed in indicator-messages: | |
status: | In Progress → Fix Committed |
Launchpad Janitor (janitor) wrote : | #4 |
This bug was fixed in the package indicator-messages - 13.10.1+
---------------
indicator-messages (13.10.
[ Lars Uebernickel ]
* libmessaging-menu: default MessagingMenuMe
TRUE In most cases, apps will want to draw the user's attention when
they add a message to the menu. (LP: #1215644)
[ Ubuntu daily release ]
* Automatic snapshot from revision 372
-- Ubuntu daily release <email address hidden> Fri, 30 Aug 2013 10:07:39 +0000
Changed in indicator-messages (Ubuntu): | |
status: | Confirmed → Fix Released |
Lars Karlitski (larsu) wrote : | #5 |
Note: the right icon probably still doesn't show up on the phone until lp:~nick-dedekind/unity8/unitymenumodel.messages lands. indicator-messages uses a new way of serializing GIcons that the current unity8 doesn't understand.
Changed in indicator-messages: | |
status: | Fix Committed → Fix Released |
Jamie Strandboge (jdstrand) wrote : | #6 |
This bug says it the issue is fixed in 13.10.1+
Changed in unity8 (Ubuntu Saucy): | |
importance: | Undecided → High |
Launchpad Janitor (janitor) wrote : | #7 |
Status changed to 'Confirmed' because the bug affects multiple users.
Changed in unity8 (Ubuntu): | |
status: | New → Confirmed |
Changed in unity8 (Ubuntu Saucy): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
tags: | added: avengers qa-touch |
Nick Dedekind (nick-dedekind) wrote : | #8 |
unity8 fix has been released, but I think there's still an issue in indicator-messages.
Changed in unity8 (Ubuntu Saucy): | |
status: | Confirmed → Fix Released |
Bill Filler (bfiller) wrote : | #9 |
This is still an issue with image 89
unity8: 7.82+13.
indicator-messages: 13.10.1+
To reproduce:
- send text message to the phone
- the message indicator does not turn blue, yet the message is there
Changed in unity8 (Ubuntu Saucy): | |
status: | Fix Released → Confirmed |
Changed in indicator-messages (Ubuntu Saucy): | |
status: | Fix Released → Confirmed |
importance: | Undecided → High |
Changed in indicator-messages (Ubuntu Saucy): | |
assignee: | nobody → Lars Uebernickel (larsu) |
Nick Dedekind (nick-dedekind) wrote : | #10 |
I looked into this a bit last week.
There seems to be a bug somewhere between the indicator clearing/adding a message and the registered application (eg. message app) telling us that it wants to draw attention (blue icon).
I've told larsu about it.
Lars Karlitski (larsu) wrote : | #11 |
Fixed in r391, but it didn't land yet.
http://
Changed in indicator-messages (Ubuntu Saucy): | |
status: | Confirmed → Fix Released |
Jean-Baptiste Lallement (jibel) wrote : | #12 |
It works on Utopic #87, closing.
Changed in unity8 (Ubuntu): | |
status: | Confirmed → Fix Released |
Changed in unity8 (Ubuntu Saucy): | |
status: | Confirmed → Fix Released |
This is really a bug in telephony-service, which didn't call messaging_ menu_message_ set_draws_ attention( ). We probably didn't notice this bug before because chewie-client turned the messaging menu icon blue by itself.
However, I'm attaching a fix for libmessaging-menu anyway: "draws-attention" should really default to TRUE. The phone app doesn't need any updates.