Incorrect translation's template handling since the switch to cmake
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Indicator Location |
Fix Released
|
Undecided
|
Charles Kerr | ||
Network Menu |
Fix Released
|
Undecided
|
Charles Kerr | ||
Session Menu |
Fix Released
|
Undecided
|
Charles Kerr | ||
The Sound Menu |
Fix Released
|
Undecided
|
Pete Woods | ||
indicator-location (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
indicator-network (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
indicator-session (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
indicator-sound (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
pkgbinarymangler (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
The switch to cmake seems to have made the translation setup a bit harder to deal with
* Doing that in the source
$ mkdir build
$ cd build
$ cmake ..
$ make
leads to a build dir without po subdir/template
* The Ubuntu magic seems to be not working anymore:
https:/
"Building ${CMAKE_
...
None of the files in POTFILES.in contain strings marked for translation.
dh_langpack: processing files to add translation domain '${CMAKE_
dh_translations does that
" while (<CMAKELISTSFILE>) {
if ( -e 'po/POTFILES.in' ) {
}
That doesn't work great with the cmakefilelist having "set(GETTEXT_
* There doesn't seem to be a standard makefile target to update the pot? Well at least those don't work
$ make pot
$ make translations
$ make update-pot
$ make indicator-sound.pot
The result is that currently the list of string handed to translations is not updated as it should :/
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Charles Kerr (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedCMakeLists.txt (+1/-1)
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 12 lines (+1/-1)1 file modifiedCMakeLists.txt (+1/-1)
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 12 lines (+1/-1)1 file modifiedCMakeLists.txt (+1/-1)
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 12 lines (+1/-1)1 file modifiedCMakeLists.txt (+1/-1)
summary: |
- Incorrect translation template handling since the switch to cmake + Incorrect translation's template handling since the switch to cmake |
Changed in indicator-session: | |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-network: | |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-location: | |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-sound: | |
status: | New → In Progress |
Changed in indicator-session: | |
status: | New → Triaged |
Changed in indicator-network: | |
status: | New → Triaged |
Changed in indicator-location: | |
status: | New → Triaged |
Changed in indicator-sound: | |
assignee: | nobody → Pete Woods (pete-woods) |
Changed in indicator-location: | |
status: | Triaged → In Progress |
Changed in indicator-network: | |
status: | Triaged → In Progress |
Changed in indicator-session: | |
status: | Triaged → In Progress |
Changed in indicator-sound: | |
status: | Fix Committed → Fix Released |
Changed in indicator-network: | |
status: | Fix Committed → Fix Released |
Changed in indicator-session: | |
status: | Fix Committed → Fix Released |
Changed in indicator-location: | |
status: | Fix Committed → Fix Released |
I'm adding pkgbinarymangler to the list, maybe dh_translations could try to be a bit smarter about getting the domain in cases where it's a variable like there