GSource leak in retry_registration()

Bug #1244250 reported by Charles Kerr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Application Menu Indicator
Fix Released
Medium
Charles Kerr
indicator-appmenu (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The timer created to invoke retry_registration() is not removed during runtime, so every second we add in another call to g_bus_own_name().

Related branches

Charles Kerr (charlesk)
Changed in indicator-appmenu:
assignee: nobody → Charles Kerr (charlesk)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:indicator-appmenu at revision 248, scheduled for release in indicator-appmenu, milestone Unknown

Changed in indicator-appmenu:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-appmenu - 13.01.0+14.04.20131125-0ubuntu1

---------------
indicator-appmenu (13.01.0+14.04.20131125-0ubuntu1) trusty; urgency=low

  [ Charles Kerr ]
  * If we can't get the bus, exit instead of stacking g_bus_own_name()
    calls on top of each other, leaking GSources. (LP: #1244250)

  [ Sebastien Bacher ]
  * Build with -Wno-error=deprecated-declarations.

  [ Lars Uebernickel ]
  * Call gtk_widget_destroy() to break potential ref cycles Calling
    g_object_unref() is not enough for many of gtk's widgets.
  * window-menu-model: disconnect entry signal handlers by func instead
    of id entry_object_free disconnected signal handlers by id. This
    throws warnings when entry_object_free is called when disposing an
    object, because signals are already disconnected at that point. This
    patch uses g_signal_handlers_disconnect_by_func(), which works both
    when the entry is alive and being disposed.
  * WindowMenuModel: insert action groups on the toplevel menus
    Inserting them on the menu items was a workaround for the long-fixed
    cloaking-bug in libindicator. It's not supported in gtk 3.10
    anymore, because the menu tracker in gtk doesn't allow action groups
    on menu items. That's for good reasons: it's more efficient and
    consumers of that api should not modify the created menu hierarchy.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 251
 -- Ubuntu daily release <email address hidden> Mon, 25 Nov 2013 03:55:37 +0000

Changed in indicator-appmenu (Ubuntu):
status: New → Fix Released
Changed in indicator-appmenu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.