lp:unity fails to build on precise (error: ‘bamf_tab_get_xid’...) instead of checking for correct prerequisites

[Daniel van Vugt]

The current lp:unity doesn't build:

/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp: In member function ‘virtual void unity::launcher::BamfLauncherIcon::ActivateLauncherIcon(unity::launcher::ActionArg)’:
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp:267:64: error: ‘bamf_tab_get_xid’ was not declared in this scope
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp: In member function ‘std::vector<long unsigned int> unity::launcher::BamfLauncherIcon::GetFocusableWindows(unity::launcher::ActionArg, bool&, bool&)’:
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp:640:31: error: ‘bamf_application_get_focusable_child’ was not declared in this scope
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp:652:48: error: ‘bamf_tab_get_xid’ was not declared in this scope
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp:654:40: error: ‘bamf_tab_raise’ was not declared in this scope
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp: In member function ‘void unity::launcher::BamfLauncherIcon::EnsureWindowState()’:
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp:764:63: error: ‘bamf_tab_get_xid’ was not declared in this scope
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp: In member function ‘virtual void unity::launcher::BamfLauncherIcon::Quit()’:
/home/dan/bzr/unity/trunk/launcher/BamfLauncherIcon.cpp:927:41: error: ‘bamf_tab_close’ was not declared in this scope
make[2]: *** [launcher/CMakeFiles/launcher-lib.dir/BamfLauncherIcon.cpp.o] Error 1

[Daniel van Vugt (vanvugt)]

Found the cause:

revno: 2624 [merge]
author: Robert Carr <email address hidden>, Ken VanDine <email address hidden>
committer: Tarmac
branch nick: unity
timestamp: Fri 2012-08-24 11:14:33 -0400
message:
  Webapps support for unity. Fixes: . Approved by Timo Jyrinki, Marco Trevisan (Treviño).

[Jussi Pakkanen (jpakkane)]

Same with indicator-appmenu on quantal:

  CC libhud_service_a-hudwebappsource.o
../../src/hudwebappsource.c: In function ‘hud_webapp_source_should_search_app’:
../../src/hudwebappsource.c:111:7: error: implicit declaration of function ‘bamf_tab_get_xid’ [-Werror=implicit-function-declaration]
../../src/hudwebappsource.c:112:4: error: implicit declaration of function ‘bamf_tab_get_is_foreground_tab’ [-Werror=implicit-function-declaration]
../../src/hudwebappsource.c: In function ‘hud_webapp_application_source_new’:
../../src/hudwebappsource.c:159:3: error: implicit declaration of function ‘bamf_application_get_application_menu’ [-Werror=implicit-function-declaration]

[Bilal Akhtar (bilalakhtar)]

Is this an attempt to build Unity trunk (lp:unity not unity/5.0) on Precise? In that case, this bug is low priority.