Coverity SECURE_CODING - CID 10715
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Indicator Applet |
Fix Released
|
Low
|
Charles Kerr | ||
0.4 |
Fix Released
|
Low
|
Charles Kerr |
Bug Description
This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https:/
CID: 10715
Checker: SECURE_CODING
Category: No category available
CWE definition: http://
File: /tmp/buildd/
Function: egg_virtual_
Code snippet:
399 l = 0;
400 accelerator[l] = 0;
401 if (accelerator_mods & EGG_VIRTUAL_
402 {
CID 10715 - SECURE_CODING
[VERY RISKY]. Using "strcpy" can cause a buffer overflow when done incorrectly. If the destination string of a strcpy() is not large enough then anything might happen. Use strncpy() instead.
403 strcpy (accelerator + l, text_release);
404 l += sizeof (text_release) - 1;
405 }
406 if (accelerator_mods & EGG_VIRTUAL_
407 {
CID 10715 - SECURE_CODING
[VERY RISKY]. Using "strcpy" can cause a buffer overflow when done incorrectly. If the destination string of a strcpy() is not large enough then anything might happen. Use strncpy() instead.
408 strcpy (accelerator + l, text_shift);
Related branches
- Ted Gould (community): Approve
-
Diff: 150 lines (+0/-131)2 files modifiedsrc/eggaccelerators.c (+0/-128)
src/eggaccelerators.h (+0/-3)
- Ken VanDine: Pending requested
-
Diff: 77 lines (+25/-2)5 files modifiedChangeLog (+14/-0)
configure (+1/-1)
configure.ac (+1/-1)
debian/changelog (+7/-0)
src/applet-main.c (+2/-0)
Changed in indicator-applet: | |
status: | Fix Committed → Fix Released |
milestone: | none → 0.4.92 |
Source file with Coverity annotations.