Orchestrator start()/cleanup() do not return status to caller.

[Andrew Forrest]

To enhance the usability of the Orchestrator class as a reusable component, it should not catch and handle certain exceptions, without at a minimum re-raising them.

For example, if an external party (command line script or restful API server) invokes Orchestrator.start() and the operation fails, the caller does not learn of this in the most straight-forward manner: e.g. having an exception thrown. Instead any internal exception that might be of interest to the caller is caught by the Orchestrator object itself and, while a message is logged, there is no status returned to the caller.

The same situation exists for cleanup().

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47077

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47077
Committed: http://github.com/stackforge/inception/commit/e76ace191434d788259263a91ff1f24f86e482fc
Submitter: Jenkins
Branch: master

commit e76ace191434d788259263a91ff1f24f86e482fc
Author: Changbin Liu <email address hidden>
Date: Wed Sep 18 00:10:13 2013 -0400

    Add re-raise argument to start() and cleanup()

    To enhance the usability of the Orchestrator class as a reusable
    component (e.g., used by WebUI), it should not catch and handle
    certain exceptions, without at a minimum re-raising them.

    Change-Id: I4ff8320f3a275fbdbe7cf3a21c217f1cf59ddacb
    Fixes: bug #1226193