Orchestrator start()/cleanup() do not return status to caller.

Bug #1226193 reported by Andrew Forrest
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inception
Fix Released
Critical
Changbin Liu

Bug Description

To enhance the usability of the Orchestrator class as a reusable component, it should not catch and handle certain exceptions, without at a minimum re-raising them.

For example, if an external party (command line script or restful API server) invokes Orchestrator.start() and the operation fails, the caller does not learn of this in the most straight-forward manner: e.g. having an exception thrown. Instead any internal exception that might be of interest to the caller is caught by the Orchestrator object itself and, while a message is logged, there is no status returned to the caller.

The same situation exists for cleanup().

Changbin Liu (changbl)
Changed in inception:
assignee: nobody → Changbin Liu (changbl)
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to inception (master)

Fix proposed to branch: master
Review: https://review.openstack.org/47077

Changed in inception:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to inception (master)

Reviewed: https://review.openstack.org/47077
Committed: http://github.com/stackforge/inception/commit/e76ace191434d788259263a91ff1f24f86e482fc
Submitter: Jenkins
Branch: master

commit e76ace191434d788259263a91ff1f24f86e482fc
Author: Changbin Liu <email address hidden>
Date: Wed Sep 18 00:10:13 2013 -0400

    Add re-raise argument to start() and cleanup()

    To enhance the usability of the Orchestrator class as a reusable
    component (e.g., used by WebUI), it should not catch and handle
    certain exceptions, without at a minimum re-raising them.

    Change-Id: I4ff8320f3a275fbdbe7cf3a21c217f1cf59ddacb
    Fixes: bug #1226193

Changed in inception:
status: In Progress → Fix Committed
Changbin Liu (changbl)
Changed in inception:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.