Inception

Use of "install_requires" precludes using distutils

Bug #1210181 reported by Andrew Forrest on 2013-08-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Inception	Fix Released	Low	Andrew Forrest

Bug Description

The external dependency of Inception on the package "python-novaclient" can only be expressed via setuptools' "install_requires" keyword argument (because "python-novaclient" contains a hyphen and is therefore not a valid python identifier).

Since the "install_requires" keyword argument is not known to distutils.core's setup function the fall-back to using the latter should be removed (since it can't work anyway).

Tags:

Revision history for this message

Andrew Forrest (forrest-r) wrote on 2013-08-08:

Example diff for setup.py showing removal of fall-back to distutils. Edit (422 bytes, text/plain)

Changed in inception:
assignee:	nobody → Andrew Forrest (forrest-r)

Changbin Liu (changbl) on 2013-08-28

Changed in inception:
importance:	Undecided → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-28: Fix proposed to inception (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44153

Changed in inception:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-28: Fix merged to inception (master)

Reviewed: https://review.openstack.org/44153
Committed: http://github.com/stackforge/inception/commit/f00b99bb703a4e8e9a69b2f9c4e427fdf10cd876
Submitter: Jenkins
Branch: master

commit f00b99bb703a4e8e9a69b2f9c4e427fdf10cd876
Author: Andrew Forrest <email address hidden>
Date: Wed Aug 28 14:34:10 2013 -0700

Remove fallback to distutils

    Inception has dependencies that cannot be expressed using distutils so the
    code that substitutes distutils if setuptools cannot be imported should be
    removed lest it be invoked and lead to a confusing error case.

Change-Id: I8959855b3b48e6742b73770a32f7931ccc1c78ef
Fixes: bug #1210181