| 2008-10-24 17:44:39 |
Michael D. Adams |
bug |
|
|
added bug |
| 2008-10-24 17:44:39 |
Michael D. Adams |
bug |
|
|
added attachment 'r1648-warnings.patch' (r1648-warnings.patch) |
| 2008-10-29 17:56:36 |
Abdulaziz Ghuloum |
ikarus: status |
New |
Fix Committed |
|
| 2008-10-29 17:56:36 |
Abdulaziz Ghuloum |
ikarus: importance |
Undecided |
Low |
|
| 2008-10-29 17:56:36 |
Abdulaziz Ghuloum |
ikarus: statusexplanation |
|
Thanks!, fixed in rev 1653.
Re:
ikarus-collect.c:1363: warning: comparison between signed and unsigned
- the problem is "relative_distance != (int)relative_distance"
- added in r1544
- seems to be intentional but I'm not sure what the motive is or if there is a better way
- if kept should have a comment explaining what it is about
I changed that test to be:
if(((long int)relative_distance) != ((long)((int)relative_distance))){
which means: does the value change if cast to an int. I think it's as clear as C could be. :-)
BTW, and maybe I asked you this before, but what version of gcc do you use, and what flags do you give it?
|
|
| 2008-10-29 17:56:50 |
Abdulaziz Ghuloum |
ikarus: assignee |
|
aghuloum |
|
| 2008-10-29 17:56:50 |
Abdulaziz Ghuloum |
ikarus: statusexplanation |
Thanks!, fixed in rev 1653.
Re:
ikarus-collect.c:1363: warning: comparison between signed and unsigned
- the problem is "relative_distance != (int)relative_distance"
- added in r1544
- seems to be intentional but I'm not sure what the motive is or if there is a better way
- if kept should have a comment explaining what it is about
I changed that test to be:
if(((long int)relative_distance) != ((long)((int)relative_distance))){
which means: does the value change if cast to an int. I think it's as clear as C could be. :-)
BTW, and maybe I asked you this before, but what version of gcc do you use, and what flags do you give it?
|
|
|
| 2008-10-30 12:06:22 |
Michael D. Adams |
ikarus: status |
Fix Committed |
New |
|
| 2008-10-30 12:06:22 |
Michael D. Adams |
ikarus: statusexplanation |
|
Ok, a few problems cropped up when you applied the changes:
ikarus-ffi.c:191: #ifdef DEBUG_FFI has extra spaces after it
ikarus-ffi.c:325: you now have it as "void (*fn)() = (void*) ..." but assigning a void* to a void(*fn)() is not legal without a cast.
Either change it to "void (*fn)() = (void (*fn)()) ..." to explicitly do the cast or use the FFI_FN macro provided by libffi to do the cast for you.
ikarus-runtime.c:215: type of mapsize needs to be "unsigned long int" to make the comparison with size in the assert on the next line happy.
ikarus-runtime.c:258: The printf needs to use %016lx form instead of %016x form at least for the second argument which has the unsigned long mapsize in it. (Compare this with line 235 which is ok.)
|
|
| 2008-10-31 20:57:19 |
Abdulaziz Ghuloum |
ikarus: status |
New |
Fix Committed |
|
| 2008-10-31 20:57:19 |
Abdulaziz Ghuloum |
ikarus: statusexplanation |
Ok, a few problems cropped up when you applied the changes:
ikarus-ffi.c:191: #ifdef DEBUG_FFI has extra spaces after it
ikarus-ffi.c:325: you now have it as "void (*fn)() = (void*) ..." but assigning a void* to a void(*fn)() is not legal without a cast.
Either change it to "void (*fn)() = (void (*fn)()) ..." to explicitly do the cast or use the FFI_FN macro provided by libffi to do the cast for you.
ikarus-runtime.c:215: type of mapsize needs to be "unsigned long int" to make the comparison with size in the assert on the next line happy.
ikarus-runtime.c:258: The printf needs to use %016lx form instead of %016x form at least for the second argument which has the unsigned long mapsize in it. (Compare this with line 235 which is ok.)
|
Fixed again in revision 1656. |
|
| 2008-11-02 16:06:45 |
Michael D. Adams |
ikarus: status |
Fix Committed |
Confirmed |
|
| 2008-11-02 16:06:45 |
Michael D. Adams |
ikarus: statusexplanation |
Fixed again in revision 1656. |
When you fixed it, you still missed these two (maybe you are compiling with -DNDEBUG):
ikarus-runtime.c:215: type of mapsize needs to be "unsigned long int" to make the comparison with size in the assert on the next line happy.
ikarus-runtime.c:258: The printf needs to use %016lx form instead of %016x form at least for the second argument which has the unsigned long mapsize in it. (Compare this with line 235 which is ok.)
|
|
| 2008-11-16 09:44:27 |
Abdulaziz Ghuloum |
ikarus: status |
Confirmed |
Fix Committed |
|
| 2008-11-16 09:44:27 |
Abdulaziz Ghuloum |
ikarus: statusexplanation |
When you fixed it, you still missed these two (maybe you are compiling with -DNDEBUG):
ikarus-runtime.c:215: type of mapsize needs to be "unsigned long int" to make the comparison with size in the assert on the next line happy.
ikarus-runtime.c:258: The printf needs to use %016lx form instead of %016x form at least for the second argument which has the unsigned long mapsize in it. (Compare this with line 235 which is ok.)
|
Fixed in 1686.
|
|
| 2008-12-26 15:27:14 |
Abdulaziz Ghuloum |
ikarus: statusexplanation |
Fixed in 1686.
|
|
|
| 2008-12-26 15:27:14 |
Abdulaziz Ghuloum |
ikarus: milestone |
|
0.0.4 |
|
