| 2008-06-08 20:27:54 |
Derick Eddington |
description |
refill-bv-buffer: lines 714-716 use j but should they be using c1?
lookahead-char-utf8-mode: line 840 uses get-char but should it be? get-char will see the same decoding error and ignore it by advancing passed it and doing another get-char which will advance more, but since this was lookahead-char should it be consuming characters? I.e.:
> (define tip (open-bytevector-input-port '#vu8(#b10000000 65 66 67) (make-transcoder (utf-8-codec) (eol-style none) (error-handling-mode ignore))))
> (lookahead-char tip)
#\A
> (lookahead-char tip)
#\B
> (lookahead-char tip)
#\B
>
I know the port position stuff is not finished, but I noticed these:
refill-bv-buffer: lines 706-708: should refilling the buffer be advancing the port's position?
Should this give 0?
> (input-port-byte-position (open-string-input-port "foobar"))
1
> |
refill-bv-buffer: lines 714-716 use j but should they be using c1?
lookahead-char-utf8-mode: line 840 uses get-char but should it be? get-char will see the same decoding error and ignore it by advancing passed it and doing another get-char which will advance more, but since this was lookahead-char should it be consuming characters? I.e.:
> (define tip (open-bytevector-input-port '#vu8(#b10000000 65 66 67) (make-transcoder (utf-8-codec) (eol-style none) (error-handling-mode ignore))))
> (lookahead-char tip)
#\A
> (lookahead-char tip)
#\B
> (lookahead-char tip)
#\B
>
I know the port position stuff is not finished, but I noticed these:
refill-bv-buffer: lines 706-708: should refilling the buffer be advancing the port's position?
Should these give 0?
> (input-port-byte-position (open-string-input-port "foobar"))
1
> (input-port-byte-position (open-bytevector-input-port '#vu8(1 2 3 4 5)))
1
>
|
|
