Warning patrol

Bug #175346 reported by Michael D. Adams on 2007-12-10
2
Affects Status Importance Assigned to Milestone
Ikarus Scheme
Low
Abdulaziz Ghuloum

Bug Description

A few warnings found with "cd src; make -s CFLAGS='-W -Wall'":

ikarus-collect.c: In function ‘ik_collect’:
ikarus-collect.c:398: warning: implicit declaration of function ‘gettimeofday’

ikarus-main.c: In function ‘main’:
ikarus-main.c:144: warning: unused variable ‘buff’

ikarus-runtime.c: In function ‘ik_safe_alloc’:
ikarus-runtime.c:408: warning: implicit declaration of function ‘ik_collect’

scheme-script.c: In function ‘main’:
scheme-script.c:40: warning: implicit declaration of function ‘strerror’
scheme-script.c:40: warning: format ‘%s’ expects type ‘char *’, but argument 3 has type ‘int’

scheme-script.c:38: warning: unused variable ‘rv’

For the first group, you need to include <sys/time.h>. For the next to last group you need to include <string.h>. The others should be obvious.

There are other warnings, but they are all unused parameter and comparison between signed and unsigned (i.e. less important).

Abdulaziz Ghuloum (aghuloum) wrote :

removed all warning and added -Wall to configure's CFLAGS so that it's on by default now (revision 1218). Thanks.

Changed in ikarus:
assignee: nobody → aghuloum
importance: Undecided → Low
status: New → Fix Committed
Michael D. Adams (mdmkolbe) wrote :

It looks like you forgot about including <sys/time.h> in ikarus-collect.c (revno 1218). If you are not seeing the same warning, it may be a distribution difference and need an autoconf macro added (ugh).

ikarus-collect.c: In function ‘ik_collect’:
ikarus-collect.c:398: warning: implicit declaration of function ‘gettimeofday’

I fixed it in revno 1219. Yes, the warning does not show up in mac
os. Thanks.

leppie (leppie) wrote :

You can really get a lot more warnings with:
./configure CFLAGS='-pedantic -Wextra'

Abdulaziz Ghuloum (aghuloum) wrote :

This bug report is about to be closed as the fix comitted
previously will be incorporated in the next 0.0.3 release of
Ikarus Scheme, scheduled for January 31, 2008. A release
candidate tarball is available for download from:
http://www.cs.indiana.edu/~aghuloum/ikarus/ikarus-0.0.3-rc1.tar.gz
Please do test it if you have the time and report any issues
you might encounter. Thank you very much for your support.
(Sorry for the duplicates; I'm updating every open bug.)

Changed in ikarus:
milestone: none → 0.0.3
Changed in ikarus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers