Snowball: Airplane mode enabling/disabling does not work as expected.

[Abhishek Paliwal]

Description:
==========
Enable Airplane Mode - Then Disable Airplane mode.
UI does not get updated when Airplane mode is disabled. It still shows Airplane mode icon on main screen.
(After bootup Airplane icon disappears)

Expected: Airplane mode should be disabled upon de-selecting "Airplane Mode" checkbox.

Reproducible:
===========
Yes, 5/5

IMPACT:
========
Bad user experience

Steps:
==========
Issue: 1
1. Bootup device
2. Go to "Settings->Wireless and Networks->More" and select the "Airplane Mode" checkbox to Enable.
3. Now disable Airplane mode - by selecting checkbox again.
Expected: UI Airplane symbol should disappear when Airplane mode is disabled, but it does not happen.

Hardware:
==========
Snowball: V5
Other setup:
USB cable (mini B type) connected to Host machine
USB-serial port logging
HDMI-HDMI connection to Acer Monitor.

Software:
==========
https://android-build.linaro.org/builds/~linaro-android/staging-snowball/#build=90

[Abhishek Paliwal (abhishek-paliwal)]

Updated description for latest behavior.

[Amit Pundir (pundiramit)]

Marking Gingerbread open bugs to "Won't fix" state (on Linaro-Android helpdesk) as fixes are done only on ICS track now. Please raise this bug again against latest Linaro-ICS release if it still exist.

[Thomas Espersson (espersson)]

Marked this as Won't fix for the Igloo community project as focus now only is on ICS

[Veli-Matti Anttila (velimattianttila)]

Reproduced on ICS, stable Linaro Android 12.05 release, Build #7.

[Veli-Matti Anttila (velimattianttila)]

Should override network/radio parameters (if modem not connected to Snowball)

and

Remove airplane icon if totally disconnected device is not in airplane mode.
Such a fix could be (in to NetworkController.java)
...
        else if (!mDataConnected && !mWifiConnected && !mBluetoothTethered && !mWimaxConnected) {
            // pretty much totally disconnected

            combinedLabel = context.getString(R.string.status_bar_settings_signal_meter_disconnected);
            // On devices without mobile radios, we want to show the wifi icon

+/* Remove airplane icon if not in airplane mode. */
+ if ((R.drawable.stat_sys_signal_flightmode == mDataSignalIconId)
+ && !mAirplaneMode) {
+ mDataSignalIconId = R.drawable.stat_sys_signal_null;
+ }
+ if ((R.drawable.stat_sys_signal_flightmode == mPhoneSignalIconId)
+ && !mAirplaneMode) {
+ mPhoneSignalIconId = R.drawable.stat_sys_signal_null;
+ }

            combinedSignalIconId =
...