Padding is miscomputed when writing tags with extended headers
Bug #1511846 reported by
Bart Massey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
idiii |
Fix Released
|
Critical
|
Bart Massey |
Bug Description
From: Roman Cheplyaka <email address hidden>
There is a bug present in at least the latest version of the package:
when padding is calculated, the size of the extended header is not taken
into account. The calculated padding may exceed the actual padding. This
may cause writeTag to overwrite the first audio frame.
This is especially bad for VBR mp3 files, where the first audio frame
contains the Xing header. If this frame is corrupted, players may
miscalculate the total duration and play only a small part of the file.
The patch is attached.
To post a comment you must log in.
Patch validated and applied. Thanks much, Roman!