v2.3 frame flags are incorrectly described

Bug #1041836 reported by Bart Massey on 2012-08-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
idiii
High
Bart Massey

Bug Description

Sadly and bizarrely, the frame flag bits were shuffled around randomly between id3v2.3 and id3v2.4. As a result, idiii reports the flag bits incorrectly for the frames of an id3v2.3 tag.

http://www.id3.org/id3v2.3.0
http://www.id3.org/id3v2.4.0-structure

Bart Massey (bart-massey) wrote :

OK, here's a patch. It's kind of kludgy, and I'm not very proud of it. Better would be to have the frame parser return the flags as a set by semantic, rather than tuples of booleans. The latter format is obviously pretty error-prone and inextensible. The former format would allow not passing the ID3 major version redundantly in the flags types.

Bart Massey (bart-massey) wrote :

My branch of idiii pushed here contains my patch above.

Changed in idiii:
importance: Undecided → High
status: New → In Progress
assignee: nobody → Bart Massey (bart-massey)
Changed in idiii:
status: In Progress → Fix Committed
Changed in idiii:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers