Configure Calendar submenu doesn't escape inputs well

Bug #672682 reported by Joshua Blanton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ical
Fix Released
Medium
Sergei Golubchik

Bug Description

The Configure Calendar cascade submenu generation doesn't escape its input well for the calendar title (or filename, if there is no title set). This results in a crash if, for instance, you try to include a calendar with a '.' in its filename and no title.

Attached is a patch that cleans up the case by following the idea laid out in tcllib/menus.tcl - basically, generate a unique index for each menu item that's unrelated to the filename, and use that as the reference to the menu item. I tested it on some simple cases, and it seems to work correctly - but I must admit that my TCL is rusty.

Related branches

Revision history for this message
Joshua Blanton (jtblanton) wrote :
Changed in ical-tcl:
importance: Undecided → Medium
assignee: nobody → Sergei (sergii)
Revision history for this message
Sergei Golubchik (sergii) wrote :

fixed. thanks!

Changed in ical-tcl:
status: New → Fix Committed
Changed in ical-tcl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.