Cannot create a HCondition with phrase=None

[Matt Goodall]

HCondition's __init__ is decorated with a unicodeToByte decorator and therefore calls enforceUnicode to check any positional or keyword args. Unfortunately, that means you cannot do HCondition(phrase=phrase) either, where 'phrase' may be None.

It would be nice if ensureUnicode is conditionally called, e.g. for non-None args or the result of a "should I call ensureUnicode" function.

Note, It's an easy problem to work around but it's does make for slightly unintuitive code:

args = {}
if phrase:
    args['phrase'] = phrase
cond = HCondition(**args)

[Cory Dodt (corydodt)]

Looks like HDatabase.remove has the same potential issue.

[Cory Dodt (corydodt)]

Committed a change to pass None straight through for unicodeToByte. It's mainly byte strings I'm concerned about, explicit Nones should not be a problem.

[Matt Goodall (matt-goodall)]

Works for me, thanks.