Add IIO sensors ID for ACPI based platform

Bug #1962674 reported by Kai-Heng Feng
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Low
Unassigned
linux-intel-5.13 (Ubuntu)
Invalid
Undecided
Jian Hui Lee
Focal
Fix Released
Undecided
Unassigned
Jammy
Invalid
Undecided
Unassigned
Kinetic
Invalid
Undecided
Jian Hui Lee
linux-intel-iotg (Ubuntu)
New
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned
Jammy
Fix Released
Medium
Jian Hui Lee
Kinetic
Invalid
Undecided
Unassigned

Bug Description

[Impact]
On ACPI based platforms, some sensors aren't probed because driver doesn't have ACPI IDs, so they are useless.

[Fix]
For pressure sensor:
72ff282819d0526d3e4417c2a61414557981b5af iio: pressure: dps310: Add ACPI HID table

For humidity sensor:
711b6a3f4af137c4a7f759136ccd50d455095b95 iio: humidity: hdc100x: Add ACPI HID table

For accelerator sensor:
b9493d595226b598ed79b3769f7038fda1a5391b iio: accel: adxl345: Add ACPI HID table

The commit is part of patch series, for the whole series, please cherry-pick 01676b0f3b625a9aa608d5b716898e9dba2fb63e^..4781f3e0e6cadf332f49f723ba820f35960a058d

[Test]
All sensors are working under /sys/bus/iio.

[Where problems could occur]
Unless there's an ID collision, these patches don't really bring any change, hence no regression risk.

Changed in linux-intel-5.13 (Ubuntu):
assignee: nobody → Jesse Sung (wenchien)
status: New → Confirmed
tags: added: murcia oem-priority originate-from-1948746
Jesse Sung (wenchien)
Changed in linux-intel-5.13 (Ubuntu):
assignee: Jesse Sung (wenchien) → Jian Hui Lee (jianhuilee)
Jesse Sung (wenchien)
Changed in linux-intel-5.13 (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-intel-5.13/5.13.0-1011.11 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Nara Huang (narahuang) wrote :

I can confirm after update to 5.13.0-1011-intel, I can see /sys/bus/iio interfaces

tags: added: cqa-verified
Jesse Sung (wenchien)
tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (54.7 KiB)

This bug was fixed in the package linux-intel-5.13 - 5.13.0-1011.11

---------------
linux-intel-5.13 (5.13.0-1011.11) focal; urgency=medium

  * focal/linux-intel-5.13: 5.13.0-1011.11 -proposed tracker (LP: #1968865)

  * Ubuntu Server lose connection when download >1G large file (LP: #1967257)
    - bus: mhi: pci-generic: configurable network interface MRU
    - bus: mhi: pci_generic: Add mru_default for Quectel EM1xx series
    - bus: mhi: pci_generic: Add mru_default for Foxconn SDX55

  * Add IIO sensors ID for ACPI based platform (LP: #1962674)
    - iio: accel: adxl345: Convert to use dev_err_probe()
    - iio: accel: adxl345: Set driver_data for OF enumeration
    - iio: accel: adxl345: Get rid of name parameter in adxl345_core_probe()
    - iio: accel: adxl345: Make use of device properties
    - iio: accel: adxl345: Add ACPI HID table
    - iio: accel: adxl345: Extract adxl345_powerup() helper
    - iio: accel: adxl345: Drop comma in terminator entries
    - iio: accel: adxl345: Remove unneeded blank lines
    - iio: humidity: hdc100x: Add ACPI HID table
    - iio: pressure: dps310: Add ACPI HID table

  * Bail out when USB port is stuck in reset loop (LP: #1960777)
    - usb: core: Bail out when port is stuck in reset loop

  [ Ubuntu: 5.13.0-40.45~20.04.1 ]

  * focal/linux-hwe-5.13: 5.13.0-40.45~20.04.1 -proposed tracker (LP: #1967356)
  * impish/linux: 5.13.0-40.45 -proposed tracker (LP: #1966701)
  * CVE-2022-1016
    - netfilter: nf_tables: initialize registers in nft_do_chain()
  * CVE-2022-1015
    - netfilter: nf_tables: validate registers coming from userspace.
  * audit: improve audit queue handling when "audit=1" on cmdline
    (LP: #1965723) // Impish update: upstream stable patchset 2022-03-22
    (LP: #1966021)
    - audit: improve audit queue handling when "audit=1" on cmdline
  * PS/2 Keyboard wakeup from s2idle not functioning on AMD Yellow Carp platform
    (LP: #1961739)
    - PM: s2idle: ACPI: Fix wakeup interrupts handling
  * Low RX performance for 40G Solarflare NICs (LP: #1964512)
    - SAUCE: sfc: The size of the RX recycle ring should be more flexible
  * [UBUNTU 20.04] Fix SIGP processing on KVM/s390 (LP: #1962578)
    - KVM: s390: Simplify SIGP Set Arch handling
    - KVM: s390: Add a routine for setting userspace CPU state
  * Move virtual graphics drivers from linux-modules-extra to linux-modules
    (LP: #1960633)
    - [Packaging] Move VM DRM drivers into modules
  * Impish update: upstream stable patchset 2022-03-09 (LP: #1964422)
    - bnx2x: Utilize firmware 7.13.21.0
    - bnx2x: Invalidate fastpath HSI version for VFs
    - rcu: Tighten rcu_advance_cbs_nowake() checks
    - select: Fix indefinitely sleeping task in poll_schedule_timeout()
    - drm/amdgpu: Use correct VIEWPORT_DIMENSION for DCN2
    - arm64/bpf: Remove 128MB limit for BPF JIT programs
    - Bluetooth: refactor malicious adv data check
    - net: sfp: ignore disabled SFP node
    - net: stmmac: skip only stmmac_ptp_register when resume from suspend
    - s390/hypfs: include z/VM guests with access control group set
    - bpf: Guard against accessing NULL pt_regs in bpf_get_task_stack()
    - scsi: zfcp: Fix failed recovery on gon...

Changed in linux-intel-5.13 (Ubuntu):
status: Fix Committed → Fix Released
Tim Gardner (timg-tpi)
Changed in linux-intel-iotg (Ubuntu Jammy):
assignee: nobody → Jian Hui Lee (jianhuilee)
status: New → In Progress
importance: Undecided → Medium
Changed in linux-intel-5.13 (Ubuntu Focal):
status: New → Fix Released
Changed in linux-intel-5.13 (Ubuntu Kinetic):
status: Fix Released → Invalid
Changed in linux-intel-5.13 (Ubuntu Jammy):
status: New → Invalid
Changed in linux-intel-iotg (Ubuntu Focal):
status: New → Invalid
Revision history for this message
Philip Cox (philcox) wrote :

I have had to disable the ADXL345 accelerator driver in the jammy:linux-intel-iotg kernel.

The code is broken, and needs a bit of work to correct.

It was also broken in the 5.13 build, so it is not a regression. I know that it appeared to be enabled in the 5.13 config. but because of the Kconfig dependencies, it was actually disabled because it requires the ADXL34X module to be disabled. Only one can be enabled in the kernel. When I disable the 34X and enable the 345 driver, it fails because the function adxl345_i2c_remove() is not defined, but it is called.

I am going to revert the change where CONFIG_ADXL345 is enabled. The build break will need to be corrected in both the 5.13 build, and the 5.15 build.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-intel-iotg/5.15.0-1006.8 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-jammy
tags: added: verification-done-jammy
removed: verification-needed-jammy
tags: added: verification-needed-jammy
removed: verification-done-jammy
Timo Aaltonen (tjaalton)
Changed in hwe-next:
importance: Undecided → Low
tags: added: verification-done-jammy
removed: verification-needed-jammy
Changed in linux-intel-iotg (Ubuntu Jammy):
status: In Progress → Fix Released
Changed in linux-intel-iotg (Ubuntu Kinetic):
status: New → Invalid
Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.