alsa: should not load sof driver if the internal mic connects to the codec

Bug #1890231 reported by Hui Wang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
linux-oem-5.6 (Ubuntu)
Focal
Fix Released
Critical
Unassigned

Bug Description

This issue was introduced by #1872916 ("Support Intel Soundwire
in 5.6-OEM Kernel 20.04"), so focal and groovy kernels don't need
this fix.

[Impact]
We found the sof driver instead of hda driver is enabled on a dell
machine without soundwire and dmic. This will make gnome show dummy
output and users have no audio device to use.

[Fix]
When we integrated fix for #1872916, we backported 2 patches, these
2 patches enable the sof driver unconditionally for Dell comet lake
machines. There is an upstream patch to fix it, let the sof driver
enable conditionally on comet lake machines.

[Test Case]
Boot the kernel with this patch on that dell machine, check the
gnome-control-center, all audio devices exist, playback and recording
work well.

[Regression Risk]
On Dell Comet Lake machines with DMIC, the sof driver should be
enabled. Without this patch, the sof driver will be enabled unconditionally, but with this patch, the sof driver will be enabled conditionally, so it is possible to introduce a regression that on Dell Comet Lake machines, the sof driver is not enabled even the machine has DMIC.

I have tested this patch on a Dell Comet Lake dmic machines, it worked
well.

CVE References

Hui Wang (hui.wang)
Changed in linux-oem-5.6 (Ubuntu):
importance: Undecided → Critical
Changed in linux-oem-5.6 (Ubuntu Focal):
importance: Undecided → Critical
status: New → In Progress
Changed in linux-oem-5.6 (Ubuntu):
status: New → In Progress
tags: added: oem-priority originate-from-1890076 somerville
summary: - alsa: should not load sof driver if there the internal mic connects to
- the codec
+ alsa: should not load sof driver if the internal mic connects to the
+ codec
Hui Wang (hui.wang)
description: updated
description: updated
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.6 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Hui Wang (hui.wang) wrote :

Install the proposed kernel on the machine, the audio driver works well.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1023.23

---------------
linux-oem-5.6 (5.6.0-1023.23) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1023.23 -proposed tracker (LP: #1892465)

  * CVE-2020-15852
    - x86/ioperm: Fix io bitmap invalidation on Xen PV

  * Fix non-working USB devices plugged during system sleep (LP: #1892678)
    - xhci: Do warm-reset when both CAS and XDEV_RESUME are set

  * ASPM not enabled on child devices behind VMD controller (LP: #1889384)
    - SAUCE: PCI/ASPM: Enable ASPM for links under VMD domain

  * Fix non-working Goodix touchpad after system sleep (LP: #1891998)
    - HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands

  * [SRU] Fix acpi backlight issue on some thinkpads (LP: #1892010)
    - platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

 -- Timo Aaltonen <email address hidden> Tue, 25 Aug 2020 08:46:08 +0300

Changed in linux-oem-5.6 (Ubuntu Focal):
status: Fix Committed → Fix Released
Mathew Hodson (mhodson)
no longer affects: linux-oem-5.6 (Ubuntu)
Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.