Lenovo m490/k4350/b580/L530/k29 - ACPI Warnings for \_SB_.PCI0.LPCB.H_EC.LED_

[James M. Leddy]

Suspend and hibernate stress test got failed with following errors in logs:
s3: HIGH Kernel message: [10512.177806] ACPI Warning: For \_SB_.PCI0.LPCB.H_EC.LED_: Excess arguments - needs 1, found 2 (20110623/nspredef-326)
s4: HIGH Kernel message: [11728.328110] ACPI Warning: For \_SB_.PCI0.LPCB.H_EC.LED_: Excess arguments - needs 1, found 2 (20110623/nspredef-326)

Steps:
1. Log into desktop
2. Run s3/s4 stress test for 30 times

Expected results:
Suspend and hibernate stress got passed without any error

Actual results:
s3/s4 got failures in log file

Diagnosis:

This warning is generated by the ACPI LED method expects 1 argument, but the kernel driver thinkpad_acpi.c function led_set_status will evaluate the ACPI LED method with two arguments (let and led_status):
                    Method (LED, 1, NotSerialized)
                    {
                        If (H8DR)
                        {
                            Store (Arg0, MLED)
                        }
                        Else
                        {
                            And (RBEC (0x0B), 0xFD, Local0)
                            Or (Local0, Arg0, Local0)
                            WBEC (0x0B, Local0)
                        }
                    }

and I also checked with lenovo thiinkpad x220, x200, seems it accepts two arguments in ACPI LED method:
                    Method (LED, 2, NotSerialized)
                    {
                        Or (Arg0, Arg1, Local0)
                        If (\H8DR)
                        {
                            Store (Local0, HLCL)
                        }
                        Else
                        {
                            \WBEC (0x0C, Local0)
                        }
                    }

It seems the spec change, if yes, we might need the spec.

[James M. Leddy (jm-leddy)]

This is either a bios problem, or a problem with hwe-thinkpad module at present.

[Brad Figg (brad-figg)]

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1118657

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[James M. Leddy (jm-leddy)]

The latest spec is using MMTS method for LED. ACPI LED method is no longer used. This applies to all ThinkPad models. As such, we want to disable newer Lenovo machines from using ACPI to set these LEDs. This patch sets up a blacklist for this.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "blacklist-acpi-led-new-thinkpads.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Adam Lee (adam8157)]

I submitted three patches to upstream

https://patchwork.kernel.org/patch/2692291/ 1/3
https://patchwork.kernel.org/patch/2685061/ 2/3
https://patchwork.kernel.org/patch/2685071/ 3/3

[1/3] and [2/3] were applied to subtree, the third one weren't because maintainer doesn't like the blacklist way.

I tried to find a generic detect method, but failed to find it in the spec I got. This bug is blocked, set the status to incomplete

[Rolf Leggewie (r0lf)]

This ticket is set to incomplete without any open question left to answer by the OP. Reverting..

[Adam Lee (adam8157)]

Really don't have other ideas than blacklist(as the spec I got), but upstream doesn't accept, close as Won't fix.