"Change desktop background" dialog shows up when using "Set as desktop wallpaper" option in image viewer

[florin]

Distribution: Ubuntu 9.10 Karmic Koala

Input: Double click picture in Nautilus (opens the picture viewer - Eye of Gnome 2.28.1), right click on the picture and select "Set as desktop background"

Expected: Image set as desktop wallpaper

Deviation: Image is set as wallpaper, but the "Appearance preferences" dialog gets activated ("Background" tab)

Papercut: If someone wants to try several pictures as background, the system opens up multiple instances of "Appearance preferences" dialog

[Omer Akram (om26er)]

yes i accept this is really annoying

[Omer Akram (om26er)]

Thank you for your bug report. This bug has been reported to the developers of the software. You can track it and make comments at: https://bugzilla.gnome.org/show_bug.cgi?id=606935

[Vish (vish)]

I doubt that this is a trivially fixable bug. Any ideas ?

[Andreas Moog (ampelbein)]

For reference, eog opens the preferences window, in eog-window.c, around line 2827:

eog_window_set_wallpaper (EogWindow *window, const gchar *filename)
{
        EogWindowPrivate *priv = EOG_WINDOW_GET_PRIVATE (window);
        GdkScreen *screen;

        gconf_client_set_string (priv->client,
                                 EOG_CONF_DESKTOP_WALLPAPER,
                                 filename,
                                 NULL);

        screen = gtk_widget_get_screen (GTK_WIDGET (window));
        gdk_spawn_command_line_on_screen (screen,
                                          "gnome-appearance-properties"
                                          " --show-page=background",
                                          NULL);
}

[Vish (vish)]

Thanks Andreas.

[Manish Sinha (मनीष सिन्हा) (manishsinha)]

I tried removing the function call "gtk_widget_get_screen" and compiling the eog. It works as per the needs.
I have reviewed it and the patch is minor. Find the patch attached.

[Manish Sinha (मनीष सिन्हा) (manishsinha)]

I am going to fix this patch. Will try to get this bug merged in the dev branch tomorrow. Need help from IRC

[Manish Sinha (मनीष सिन्हा) (manishsinha)]

I am going to work on this. Will try to get this bug merged in the dev branch tomorrow. Need help from IRC

[Vish (vish)]

I believe, the reason EOG devs have implemented the current behavior is , in case the user does not like the wallpaper and wants to revert the wallpaper back to the old one.

So , instead of removing the behavior , we could move the function to the ribbon EOG uses.
The ribbon can mention
" 'Fav_pic.png' has been set as Desktop wallpaper " [Revert] [OK]
 and the 'Revert' now opens the appearance prefs dialogue window.

[Manish Sinha (मनीष सिन्हा) (manishsinha)]

Vish,
Check the code snippet. The wallpaper gets set and then gnome-appearance opens and not the other way round.
I am curious how [Revert] can be implemented. I haven't seen any such feature in gnome-appearance. If anyone just wants to revert back he has to memorise it. This invalided the need to open gnome-appearance.

[Vish (vish)]

@Manish Sinha:
Yes , wallpaper is set and only then the gnome-appearance window is brought up. We block that and move the function to the button

The revert button , brings up the gnome-appearance window and allows the user to select the wallpaper.
We dont actually have to revert it to the old wallpaper.
We could label the button 'Change' too.

[Vish (vish)]

Unassigning as , Fix has been committed upstream.

[Launchpad Janitor (janitor)]

This bug was fixed in the package eog - 2.29.90-0ubuntu1

---------------
eog (2.29.90-0ubuntu1) lucid; urgency=low

  * New upstream version:
    - Further GSEAL-compatibility improvements
    - Allow switching to a random image from the collection
    - Build fixes
    - Ask user if he actually needs the Appearance capplet after setting a new
      desktop wallpaper through Eye of GNOME (lp: #503061)
    Bug fixes:
    - #606935, "Change desktop background" dialog shows up when using
      "Set as desktop wallpaper" option in image viewer
    - #609184, Build failure: doesn't look for some required libs
    New and updated translations
 -- Sebastien Bacher <email address hidden> Tue, 09 Feb 2010 23:57:36 +0100