Hugin should support the lensfun lens database

Bug #696634 reported by Bruno Postle
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Hugin
Fix Released
Wishlist
Unassigned

Bug Description

lensfun is a database and library that allows applications to access and save lens correction settings: http://lensfun.berlios.de/

lensfun was in part designed for Hugin as a replacement for the existing .ini lens saving system, it is mature and has been adopted by ufraw and rawstudio, it is about time that Hugin started using it.

tmodes (tmodes)
Changed in hugin:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: lens lensdatabase
Revision history for this message
tmodes (tmodes) wrote :

I had a short look on lensfun. Some comments from me:

1.) Lensfun stores only a very rough lens types:
From the doc: <type>string</type> Lens type. This is one of: "rectilinear", "fisheye", "panoramic", "equirectangular".
But hugin has e.g. a finer grain for fisheye lenses (full frame fisheye, circular fisheye, thoby, orthographic?) So how do we handle this cases?
2.) For fisheye lenses the crop rectangle/circle is not stored in the database. But I think this is needed for hugin needs.
3.) Lensfuns does currently not support a native windows compile. It supports only cross compile, that means you need a linux system to generate the lib for the windows version. We need to find a solution for this.

Revision history for this message
tmodes (tmodes) wrote :

Short update:
I patched the lensfun library to fix the mentioned issues. The patches were uploaded to the lensfun patch tracker.

Revision history for this message
Bruno Postle (brunopostle) wrote :
Revision history for this message
tmodes (tmodes) wrote :

Implemented in changeset f09bd1ceb2a8

Changed in hugin:
status: Triaged → Fix Committed
Revision history for this message
Bruno Postle (brunopostle) wrote :

Thanks, links, builds and runs on fedora f15.

f15 has an old version of lensfun (0.2.5), so this report is probably not very useful:

I have a compact Panasonic Lumix LX3, which is in the database, the lens entry looks like this:

        <maker>Leica</maker>
        <model>Standard</model>
        <mount>panasonicLX3</mount>
              ...

I can only get a search match in Hugin with the string 'standard', unfortunately there are 86 lenses called 'standard' in the database, so it isn't practical to select the right one.

Revision history for this message
Bruno Postle (brunopostle) wrote :

Hi Thomas, current 6916593231ee works with the compact LX3 camera. Loading the lens using lensfun adds plausible lens distortion parameters, but doesn't alter the field-of-view - Looking at the lensfun patch, this is a limitation of the older lensfun I have here.

A minor thing: in the 'load lens from database' window, the values for focal length and aperture are rounded to the nearest whole number, these would both be better as "focal length: 5.1mm, Aperture f/4.0" rather than "focal length: 5mm, Aperture f/4".

BTW it builds fine on fedora f15, f16, f17 & f18, all with both i386 and x86_64.

Revision history for this message
tmodes (tmodes) wrote :

Hi Bruno,

I committed a change to display the focal length with one decimal place. The aperture was already displayed with one decimal place. When the decimal place contains only zero, it is not displayed - so no rounding.

Also the writing to the database was improved for compact camera. I hope, this works correctly.

tmodes (tmodes)
Changed in hugin:
milestone: none → 2012.0beta1
hvdwolf (hvdwolf)
Changed in hugin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.