Swap images in controlpoints window.

Bug #679919 reported by rew on 2009-04-25
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Wishlist
Unassigned

Bug Description

If the two images in the control point tab align, but have been taken right-to-left, it is easier to work on the middle area, than to work on the left side of the left image, and on the right side of the right image. So I usually swap them. It might be useful to have a button do this instead of having to change both image selectors.

rew (r-e-wolff) wrote :

Still should be done in newest version.

Changed in hugin:
status: New → Confirmed
importance: Undecided → Low
tmodes (tmodes) on 2010-11-25
Changed in hugin:
importance: Low → Wishlist
Yuv (yuv) wrote :

related to bug #679726

onomou (onomou) wrote :

Here's a patch that may add this functionality. I tested it in Ubuntu 11.04 - it did require a bit of modification of the XRC file, which I used XRCed and CodeBlocks for (hope it didn't bork it too badly).

Changed in hugin:
status: Confirmed → New

Hi,

Your patch contains sometimes differences to the original in tabs/spaces.

     XRCCTRL(*this, "cp_editor_celeste_button", wxButton)->Disable();
     XRCCTRL(*this, "cp_editor_choice_zoom", wxChoice)->Disable();
     XRCCTRL(*this, "cp_editor_previous_img", wxButton)->Disable();
+ XRCCTRL(*this, "cp_editor_swap_img", wxButton)->Disable();
     XRCCTRL(*this, "cp_editor_next_img", wxButton)->Disable();

You probably used a tab, while the original uses spaces (and less than
8). To get your code accepted please go through your patch and copy
the tabs/spaces from the lines above or below the line you patched.

Thanks! Looks good!

 Roger.

--
** <email address hidden> ** http://www.BitWizard.nl/ ** +31-15-2600998 **
** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
Does it sit on the couch all day? Is it unemployed? Please be specific!
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ

onomou (onomou) wrote :

Right Roger. Good point. Here it is again. I forgot which system this project uses and set up my text editor for tabs instead of spaces. It sure is confusing to have stuff already mixed in a file (it appears half the sections in this patch have spaces, half have tabs) - what do you suggest for such files?

onomou (onomou) wrote :

Oops! And the patch...

rew (r-e-wolff) wrote :

Just copy over the lines around the line you've changed. If there are already differences, consider contacting the lead developers with: "I want to clean up the spaces/tabs situation will you accept a 'whitespace only' patch?".

but when a line you've changed stands out by indentation in the patch, that's when you've not used the indentation style of the lines around your patch.... :-)

rew (r-e-wolff) wrote :

The XML file that changed in your patch, is that machine-generated? It seems something weird is going on there too with the whitespace. What does "diff -b" say about the differences besides the whitespace?

tmodes (tmodes) wrote :

Using the space bar is not to good on windows. The space bar is already in use on windows for select options. So please don't use it for some other functions.

onomou (onomou) wrote :

Ok, good point tmodes. I forgot about Windows. What do you suggest in its place?

Yuv (yuv) on 2011-07-19
Changed in hugin:
status: New → In Progress
importance: Wishlist → High
tmodes (tmodes) on 2011-10-06
Changed in hugin:
status: In Progress → Triaged
importance: High → Wishlist
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers