Better exception handling for deghosting tools

Bug #679718 reported by Iouri Ivliev on 2009-10-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Medium
Lukas Jirkovsky

Bug Description

what() function in BadDimensions and NoImages classes should be 'const' to override std::exception's what() properly.
patch-src-tools-hugin_hdrmerge.cpp.diff contains also quick&dirty hack to restore alpha channel in image produced by khan algorithm. This isn't "Right Way", but allows to use combined image stacks with enblend. Just IMHO, Deghosting class shouldn't check input images dimensions in loadImages() functions. An overlapping rectangle should be calculated using input images bitmap sizes, page offsets and alpha channels. Sizes and offsets of this rectangle should be used as sizes and offsets of output image. Alpha channel of output image should be made as intersection or joining of input images alpha channels.

Iouri Ivliev (lp-0o6vs1) wrote :

The file patch-deghosting.tar.gz was added: None

Lukas Jirkovsky (l-jirkovsky) wrote :

Thank you very much for the patches and suggestions. I've committed the ones which fixes exceptions.

I'll take a look at the alpha handling and computation of overlapping region later.

Yuv (yuv) wrote :

yes, thank you. would you mind sharing your name with us so we can add you to the credits page of Hugin?

Iouri Ivliev (lp-0o6vs1) wrote :

My name is Iouri Ivliev

Iouri Ivliev (lp-0o6vs1) wrote :

The file merge-wrapper.gz was added: Simple shell script wrapper to hugin_hdrmerge

Iouri Ivliev (lp-0o6vs1) wrote :

To: Lukas Jirkovsky
BTW, look at attached merge-wrapper.gz. This is gzipped shell script wrapper to hugin_hdrmerge. It calculates overlapping rectangle geometry as intersection of input images geometry and composes output alpha channel as intersection of input images alpha channels.

Yuv (yuv) on 2010-11-26
tags: added: patch
Changed in hugin:
assignee: nobody → Lukas Jirkovsky (l-jirkovsky)
status: New → Triaged
Changed in hugin:
importance: High → Medium
status: Triaged → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers