hugin invokation of make failure on MAKEFLAGS=-j2
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Hugin |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Hello,
this has originally been reported by Helmut Grohne in <http://
-------
nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_
nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_
nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_
rm blah0000.tif blah0001.tif blah0002.tif
enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah0000.tif blah0001.tif blah0002.tif
enblend: error opening input file "blah0000.tif":
Precondition violation!
Unable to open file 'blah0000.tif'.
make: *** [blah.tif] Fehler 1
-------
Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes "make all clean". With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel):
1a nona for image 1
1b nona for image 2
------
2a nona for image 3
2b rm temporary files, including the output the first nona invocations
------
3a run enblend, which fails due to missing files.
The correct fix is to only run clean after all has finished (make all && make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable.
See also <https:/
This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes "make test all clean".
thanks, cu andreas
Changed in hugin: | |
milestone: | none → 2012.0beta1 |
Changed in hugin: | |
status: | Fix Committed → Fix Released |
can anybody verify if this still happens with the new Makefilelib in 2010.4 ?