[PATCH] proper check for sys/sysctl.h at build time

Bug #1802790 reported by Pino Toscano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Fix Released
Undecided
Unassigned

Bug Description

The "platform" part of "hugin_utils" has an hardcoded list of platforms where sys/sysctl.h is not present (basically Windows, and Solaris). This is because sys/sysctl.h is not a standard POSIX header.
OTOH, there are more platforms without that header, for example GNU/Hurd.

A better way is to check whether sys/sysctl.h exists, and include it only in that case. Attached there is a hg commit that does this.

Revision history for this message
Pino Toscano (pinotree) wrote :
Revision history for this message
tmodes (tmodes) wrote :

Thanks for the patch.
But the code in the mentioned file was not used anymore. So I removed the whole file without the need to change the build system.

Changed in hugin:
status: New → Fix Committed
milestone: none → 2018.2beta1
Revision history for this message
Pino Toscano (pinotree) wrote :

Even better, thanks!

tmodes (tmodes)
Changed in hugin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.