Importing DNG files using RawTherapee fails

[Bicyclops]

I clicked on Edit > Import Raw Files, changed the filter to "All files (*)" (see bug 1801512), selected some DNG files (from Adobe DNG Converter 11.0), clicked "Import", and it failed with:

Executing: /home/morgan/programs/rawtherapee/rawtherapee-cli -O /home/morgan/photos/2018-10-17/2018-10-17\ 1\ 03.tif -p /tmp/rt.pp3 -s -p /tmp/.mount_Hugin_obDWOJ/usr/share/hugin/datahugin_rt.pp3 -tz -Y -c /home/morgan/photos/2018-10-17/2018-10-17\ 1\ 03.dng
RawTherapee, version 5.4-1075-gd75741a99, command line.
Error: "/tmp/.mount_Hugin_obDWOJ/usr/share/hugin/datahugin_rt.pp3" not found.

What is datahugin_rt.pp3?

Recommendations:
1. Hugin should allow the user to specify a custom processing profile, or use the one alongside the file if one exists. And it does - good! It does so thanks to specifying a custom -p before -s.
2. Use uncompressed 16-bit TIFF files as intermediate files, because they are fast to write and the user loses no image quality along the way. Hugin does not handle 32-bit files correctly yet.

Changing the above command as needed, the final command should look as follows:

"${HOME}/programs/rawtherapee/rawtherapee-cli" -O "/tmp/2018-10-17 1 03.tif" -p /tmp/rt.pp3 -s -b16 -t -Y -c "/home/morgan/photos/2018-10-17/2018-10-17 1 03.dng"

[Bicyclops (bugs-8)]

This error might be related to the AppImage and not to Hugin itself:
Error: "/tmp/.mount_Hugin_obDWOJ/usr/share/hugin/datahugin_rt.pp3" not found.

I will contact Carmelo to doublecheck:
https://discuss.pixls.us/t/rawtherapee-integration-with-hugin/9625/9

However, please consider my suggestions regarding changing that command line per recommendations.

[tmodes (tmodes)]

> What is datahugin_rt.pp3?
I should be data/hugin_rt.pp3. In this I reset all crop because the optical model assume that the optical center and the image center are identical.

>2. Use uncompressed 16-bit TIFF files as intermediate files,
Hugins default for the remapped files is LZW compressed TIFF files. So I used the same format also for the developed raw files.

> Changing the above command as needed, the final command should look as follows:
According to https://rawpedia.rawtherapee.com/Command-Line_Options -b16 is the default:
     -b<8|16>

        Specify bit depth per channel (16 by default).
        Only applies to TIFF and PNG output, JPEG is always 8.

    -t[z]

        Specify output to be TIFF (16-bit if -b8 is not set).

Is the documentation wrong? Or is -b16 really the default?

[Bicyclops (bugs-8)]

> In this I reset all crop because the optical model assume that the optical center and the image center are identical.

Sounds good.

> Hugins default for the remapped files is LZW compressed TIFF files. So I used the same format also for the developed raw files.

As these file are nothing more than intermediate files and therefore storage space is of no concern, I recommend no compression to save time.

> -b16 is the default

You're right, and I just checked and confirm. Personally I like to specify things explicitly.

[Bicyclops (bugs-8)]

I just found a bug in RawTherapee which lead to corrupt saved images when the bit depth was not explicitly specified. Fixing it now for RawTherapee 5.5, but I would recommend that Hugin specifies it explicitly.

[tmodes (tmodes)]

Done. I added the -b16 switch for the RT processing.