PATCH: speed improvements
Bug #1778802 reported by
Vladimir Nadvornik
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Hugin |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I tried to profile hugin on a large project with 500 images and 100000 control points. I identified and fixed some bottlenecks:
ImageVariable.patch - reimplemented ImageVariable with shared_ptr - reduces complexity from O(n) to O(1)
ImageVariableGr
GreatCircles.patch - reduce number of segments for short lines
GreatCircles-
Changed in hugin: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks you for your work. patch: This I need to check. This is a big change and I want to understand it before committing it.
Some comments:
ImageVariable.
ImageVariableGr oup.patch: This code and similar one is used at several places. Would it also help to inline the getimage function to achieve the same/similar speed improvement?
GreatCircles.patch: Already pushed to repository.
GreatCircles- image.patch: Instead of the workaround (and the same or similar code is used at several places through the whole repository) we should fix the initialization of the SrcPanoImage class. I tried to rewrite the initialization of this class with modern C++. Could you please try if the attached patch brings the same effect?