assistant fails to run if custom temporary directory is set

[Andreas Metzler]

If preferences->file name->Temporary dir is set to an non-empty value, running from cpfind from the Assistant ([2. Align]-button]) fails. The cpfind window pops up and closes immediately, an error message about unconnected images is shown.

Running cpfind from the main window ([Photos]->[Create control points]) still works.

Googling finds a thread on hugin-ptx but no solution:
https://<email address hidden>/msg24909.html
https://groups.google.com/forum/#!msg/hugin-ptx/w_oeNy9rqDE/8qRP5UJzAgAJ
| Greg 'groggy' Lehey Fri, 16 Sep 2016 18:00:47 -0700
| [...]
| For the record: setting that variable (which ends up in ~/.hugin as
| tmpDir=/var/tmp, for example) appears to cause hugin pass an empty
| PATH environment variable to icpfind, which then fails. It's not the
| problem of icpfind, which works fine if started directly. But I
| haven't had time to track it down yet.

[tmodes (tmodes)]

Fixed in repository.

PS: For diagnosing there is the option "Copy log messages to clipboard" in the preferences. Then you can paste the full log of the failed step.

[Andreas Metzler (k-launchpad-downhill-at-eu-org)]

On 2017-02-25 tmodes <email address hidden> wrote:
> Fixed in repository.

> PS: For diagnosing there is the option "Copy log messages to clipboard"
> in the preferences. Then you can paste the full log of the failed step.

> ** Summary changed:

> - cpfind fails to run if custom temporary directory is set
> + assistant fails to run if custom temporary directory is set
[...]

Is the fix easy to cherrypick? Could you point out the fixing commit?

Thanks, cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

[tmodes (tmodes)]

> Is the fix easy to cherrypick?

Yes. It is an one liner.

> Could you point out the fixing commit?
Changeset 401823447b21. The log message explicitly mentions the bug number: Fixes running assistant with user defined temp directory [1666030]