Default branch problems in Fedora 24

[tduell]

The default branch (hugin-2016.3.0.1e53df29f670) builds without error in fedora 24 x86_64 but there are display problems.
Image 'Selection_006.jpg' shows the window when it first opens.
Image 'Selection_007.jpg' shows the window after a slight drag from bottom RH corner.
Image 'Selection_008.jpg' shows that the menus exist, but the menu names are not displayed.
Image 'About Hugin_009.jpg' shows the build details.

[tduell (tduell-iinet)]

Sorry, I should have zipped all the screenshots into a single file.

[tmodes (tmodes)]

Hi Terry,

I can't reproduce this.

On Fedora 23 in a virtual machine all works fine.

The only difference I see is an older GTK version on my side (from the about screen):

wxWidgets: wxWidgets 3.0.2
wxWidgets Library (wxGTK port)
Version 3.0.2 (Unicode: wchar_t, debug level: 1),
compiled at May 6 2016 00:17:42

Runtime version of toolkit used is 3.18.
Compile-time GTK+ version is 3.18.9.

[tduell (tduell-iinet)]

Hello Thomas,
I also have no problem here with Fedora 23, the problem is with Fedora 24 and suspect the problem is the changes that it brings.

Cheers,
Terry

[tmodes (tmodes)]

Hi Terry,

then it would be interesting what changed in Fedora 24 and if this needs fixed upstreams in wxWidgets or if we need changes to Hugin source code.

[tduell (tduell-iinet)]

Hello Thomas,
It looks like runtime toolkit is now 3.20 and compile time is 3.20.2 but don't know if this brought any change that would cause what I'm seeing. Fedora 24 is also using gcc-6.1.1, could this have an influence?
It would be good if someone who has Fedora 24 x86_64 could test build and see if the issue is reproduced.
I use the Cinnamon desktop and pondered if there might be an issue there, so installed gnome, but the result is the same.

Cheers,
Terry

[tduell (tduell-iinet)]

There was a bug reported here <https://bugzilla.redhat.com/show_bug.cgi?id=1345924> that had an issue with wxGTK3, and noted that the problem was fixed by building against wxGTK, but we have passed the point where I could try that.
It may not be related.

Cheers,
Terry

[tmodes (tmodes)]

The problem with the missing menubar seems to be a combination of wxWidgets and GTK3. see ticker http://trac.wxwidgets.org/ticket/17539
Best would be to update the wxWidgets version with this fix.
A workaround could be to remove the wxTB_DOCKABLE style from the toolbar, as the ticket mentions that it only happens with this style.
Edit src/hugin1/hugin/xrc/main_tool.xrc, line 4. Change from
    <style>wxTB_FLAT|wxTB_DOCKABLE</style>
to
    <style>wxTB_FLAT</style>

But the problem with the sizers remains.

[tduell (tduell-iinet)]

Hello Thomas,
I've tied the workaround described in your post #11, and we get the icons back but still no menu names displayed.

Cheers,
Terry

[tmodes (tmodes)]

Hi Terry,

for the menu we need to remove the dockable style also from the menus.
I committed a fix to the default branch, which removes all dockable styles. This should fix the issue with the toolbars and menubars.
If you have tested it and it works then the following questions arise: should this patch also go into 2016.2 branch?

For the sizer issue: there is a bug report in the wxWidgets tracker http://trac.wxwidgets.org/ticket/17585 Maybe it gets fixed upstreams.

[tduell (tduell-iinet)]

Hello Thomas,
I have just tested a build of the default branch and all is OK except for the sizer issue.
I assume you have tested these changes in Fedora 23, and if OK then would guess it is OK for the patch to go into the 2016.2 branch.
Any builds of 2016.2 that use the later tools may still have the sizer problem (if it takes a while to be fixed upstream) but that is easily overcome by the user.

Cheers,
Terry

[tmodes (tmodes)]

Fixed upstreams.
See https://groups.google.com/forum/#!topic/hugin-ptx/3GqEi6pGnT4