Scripting interface does not respect const qualifier
Bug #1195436 reported by
tmodes
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Hugin |
Confirmed
|
Undecided
|
KFJ |
Bug Description
The script interface does not respect the const qualifier to some (member) functions.
E.g. Panorama::GetImages returns a const SrcImage. In C++ you can not modify it, but it works in Python. So in the scripting interface also the const qualifier should be respected.
Changed in hugin: | |
assignee: | nobody → KFJ (kfj) |
status: | New → Confirmed |
To post a comment you must log in.
On 27.06.2013 21:20, Launchpad Bug Tracker wrote:
> tmodes (tmodes) has assigned this bug to you for Hugin:
>
> The script interface does not respect the const qualifier to some (member) functions.
> E.g. Panorama::GetImages returns a const SrcImage. In C++ you can not modify it, but it works in Python. So in the scripting interface also the const qualifier should be respected.
>
> ** Affects: hugin
> Importance: Undecided
> Assignee: KFJ (kfj)
> Status: Confirmed
Well, thanks for assigning me this task, but I fear I won't be able do
anything about it. Have a look at
http:// www.swig. org/Doc2. 0/SWIGDocumenta tion.html# SWIGPlus_ const
I don't think making the python interface respect all uses of const is the-whole- header approach. Going into the details would
an easy task, if at all feasible. If you look at the i-file, you'll see
that I have very rarely wrapped anything specific, but instead used the
feed-swig-
require way more work.
I do think though that the complete state of the Panorama is stored
before any plugin is called, and so all changes which might lead into
trouble because const is not honoured can be undone after the plugin's
run. And if you want to be on the safe side you can always store the
panorama before the plugin is called.
Kay