shouldn't list inactive items

Bug #1192646 reported by Sebastien Bacher on 2013-06-19
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Unity HUD
Fix Released
High
Ted Gould
13.10
Fix Released
High
Ted Gould
hud (Ubuntu)
High
Unassigned
Saucy
High
Unassigned

Bug Description

[Impact]
All Ubuntu users using Unity and the HUD.

[Test case]
- start gedit
- open the hud
- look for "undo"

It lists the "undo" item from the edit menu, it shouldn't since there is nothing to undo and the menu item is greyed out.

[Regression potential]
Since this changes how menu items are identified on whether or not they need to be shown, there could be unforeseen issues where menu items that should be appearing and used to be appearing are now hidden and considered unavailable. Items that just recently became available may not be visible in the hud.

Related branches

Christian Dywan (kalikiana) wrote :

I see the same issue (working on bug 1186965), the HUD doesn't hide disabled actions.

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in hud (Ubuntu):
status: New → Confirmed
Changed in hud (Ubuntu):
importance: Undecided → High
Changed in hud:
assignee: nobody → Ted Gould (ted)
importance: Undecided → High
Ted Gould (ted) on 2013-10-08
summary: - shouldn't list unactive items
+ shouldn't list inactive items
Pete Woods (pete-woods) wrote :

Digging around the code a bit, it seems the problem is that we aren't reading the enabled status from the gmenumodel in menumodel-collector.c.

I have no idea if this is possible (should be easy, right? but can't find a simple "enabled" attribute or anything obvious like that).

The rest of the codebase understands the idea of enabled and disabled HUD items, so if we read and track the enabled status of the gmenumodel item, that should be it.

PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:hud/13.10 at revision None, scheduled for release in hud, milestone Unknown

Changed in hud:
status: In Progress → Fix Committed
description: updated
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in hud (Ubuntu Saucy):
status: New → Confirmed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hud - 13.10.1+14.04.20131029.1-0ubuntu1

---------------
hud (13.10.1+14.04.20131029.1-0ubuntu1) trusty; urgency=low

  [ Pete Woods ]
  * Fix the ref counting of application sources The application sources
    are now entirely owned by the application-list's hash table.

  [ Ted Gould ]
  * Add apport dependencies to the package hook. (LP: #1233994)
  * Don't show disabled items in search results. (LP: #1192646)

  [ Charles Kerr ]
  * Add a nullptr safeguard to prevent a crash-on-null-ptr-reference.
    Also, move a QMap lookup outside of a for loop. Yay! . (LP:
    #1242032)
  * if we can't get the busname, log a g_critical and then exit
    gracefully instead of abort()ing in g_error. (LP: #1244688)
  * Add a null safeguard when accessing window SharedPtrs held in the
    m_windows QMap . (LP: #1243654)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 343
 -- Ubuntu daily release <email address hidden> Tue, 29 Oct 2013 11:17:56 +0000

Changed in hud (Ubuntu):
status: Confirmed → Fix Released

Hello Sebastien, or anyone else affected,

Accepted hud into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/hud/13.10.1+13.10.20131024-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in hud (Ubuntu Saucy):
status: Confirmed → Fix Committed
tags: added: verification-needed
Miklos Juhasz (mjuhasz) wrote :

I have installed the proposed package and followed the test case. The Undo menu item is not listed by the hud so the proposed package fixed this bug.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hud - 13.10.1+13.10.20131024-0ubuntu1

---------------
hud (13.10.1+13.10.20131024-0ubuntu1) saucy; urgency=low

  [ Pete Woods ]
  * Fix the ref counting of application sources The application sources
    are now entirely owned by the application-list's hash table.

  [ Ted Gould ]
  * Add apport dependencies to the package hook. (LP: #1233994)
  * Don't show disabled items in search results. (LP: #1192646)
  * Don't crash if we get asked about a window we don't know about,
    return a null list. (LP: #1242339)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 341
 -- Ubuntu daily release <email address hidden> Thu, 24 Oct 2013 16:12:43 +0000

Changed in hud (Ubuntu Saucy):
status: Fix Committed → Fix Released
Changed in hud (Ubuntu Saucy):
importance: Undecided → High
Changed in hud:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers