hp-check uses build time component (cups-config) during run-time check
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HPLIP |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
hp-check is using a build time component (cups-config) to do its run
time dependency checking. That is the issue.
hp-check doesn't depend on cups-config, Without libcups2-dev it reports
incorrectly (run time -r):
$ hp-check -r
[...]
Checking for CUPS...
Status: scheduler is running
error: Version: (Not available. CUPS may not be installed or not running.)
[...]
Checking for dependency: CUPS - Common Unix Printing System...
OK, found.
As you can see from the results above, without libcups2-dev, hp-check does report
correctly that the scheduler is running, and that the runtime dependency for
CUPS is met. The thing it cannot determine without cups-config is what version
of CUPS we are running.
> WDYT what should we do?
Replace the runtime call on cups-config with something that will give the
version of the installed CUPS.
Unfortunately none of the binaries shipped with cups appear to report their
version:
cups:
/usr/sbin/cupsd
/usr/sbin/
cups-client:
/usr/sbin/lpadmin
/usr/sbin/
/usr/sbin/lpinfo
/usr/sbin/lpmove
/usr/sbin/cupsctl
/usr/sbin/
/usr/bin/cancel
/usr/bin/lpstat
/usr/bin/lppasswd
/usr/bin/
/usr/bin/lpoptions
/usr/bin/
/usr/bin/lp
/usr/sbin/reject
/usr/sbin/accept
/usr/sbin/
/usr/sbin/
/usr/sbin/
I would suggest with discuss with CUPS and get an Version string printed out,
possible against; lpinfo and/or cupsd -t.
http://
Mark
description: | updated |
Changed in hplip: | |
status: | Confirmed → Fix Committed |
Changed in hplip: | |
status: | Fix Committed → Fix Released |
In the meantime we should downgrade the runtime check from an error to a warning.
--- /usr/bin/hp-check 2010-04-13 06:57:57.000000000 +1000 bin/hp- check 2010-04-18 10:47:46.000000000 +1000
log. info("Version: %s" % output.strip())
+++ /usr/local/
@@ -339,9 +339,7 @@
if status == 0:
else:
- log.error("Version: (Not available. CUPS may not be installed or not running.)")
- cups_ok = False
- num_errors += 1
+ log.warn("Version: (Not available (cups-config). Unable to determine installed version of CUPS.)")
if cups_ok: cupsd.conf'
cups_conf = '/etc/cups/